Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 25 additions & 37 deletions .github/workflows/build-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -354,40 +354,28 @@ jobs:
run: |
mvn clean install -pl $EXCLUDE_MODULES -q -DskipTests -Dci
mvn verify -pl :neo4j-gremlin -DincludeNeo4j
# go:
# name: go
# timeout-minutes: 20
# needs: cache-gremlin-server-docker-image
# runs-on: ubuntu-latest
# steps:
# - name: Checkout
# uses: actions/checkout@v5
# - name: Setup Go
# uses: actions/setup-go@v5
# with:
# go-version: '1.25'
# - name: Get Cached Server Base Image
# uses: actions/cache@v4
# id: gremlin-server-test-docker-image
# with:
# path: |
# ./gremlin-server/*
# ~/.m2/repository/org/apache/tinkerpop/*
# key: ${{ github.sha }}
# - name: Load Docker Image
# working-directory: ./gremlin-server
# run: docker load --input gremlin-server.tar
# - name: Build with Maven
# working-directory: .
# run: |
# touch gremlin-go/.glv
# EXCLUDE="${EXCLUDE_MODULES/,-:gremlin-python},$EXCLUDE_FOR_GLV"
# mvn clean install -pl $EXCLUDE -q -DskipTests -Dci
# mvn verify -pl :gremlin-go
# - name: Upload to Codecov
# uses: codecov/codecov-action@v5
# with:
# working-directory: ./gremlin-go
# - name: Go-Vet
# working-directory: ./gremlin-go
# run: go vet ./...
go:
name: go
timeout-minutes: 20
needs: cache-gremlin-server-docker-image
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v5
- name: Setup Go
uses: actions/setup-go@v5
with:
go-version: '1.25'
- name: Build with Maven
working-directory: .
run: |
touch gremlin-go/.glv
EXCLUDE="${EXCLUDE_MODULES/,-:gremlin-python},$EXCLUDE_FOR_GLV"
mvn clean install -pl $EXCLUDE -q -DskipTests -Dci
mvn verify -pl :gremlin-go
- name: Upload to Codecov
uses: codecov/codecov-action@v5
with:
working-directory: ./gremlin-go
- name: Go-Vet
working-directory: ./gremlin-go
run: go vet ./...
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import org.antlr.v4.runtime.tree.TerminalNode;
import org.apache.commons.lang3.StringUtils;
import org.apache.tinkerpop.gremlin.language.grammar.GremlinParser;
import org.apache.tinkerpop.gremlin.process.traversal.TraversalStrategy;
import org.apache.tinkerpop.gremlin.process.traversal.strategy.decoration.OptionsStrategy;
import org.apache.tinkerpop.gremlin.structure.VertexProperty;
import org.apache.tinkerpop.gremlin.util.DatetimeHelper;
Expand All @@ -41,7 +42,8 @@ public class GoTranslateVisitor extends AbstractTranslateVisitor {
private final static List<String> STRATEGY_WITH_MAP_OPTS = Collections.unmodifiableList(Arrays.asList(
"OptionsStrategy",
"ReferenceElementStrategy", "ComputerFinalizationStrategy", "ProfileStrategy",
"ComputerVerificationStrategy", "StandardVerificationStrategy", "VertexProgramRestrictionStrategy"));
"ComputerVerificationStrategy", "StandardVerificationStrategy", "VertexProgramRestrictionStrategy",
"MessagePassingReductionStrategy"));
private final static List<String> STRATEGY_WITH_STRING_SLICE = Collections.unmodifiableList(Arrays.asList(
"ReservedKeysVerificationStrategy", "ProductiveByStrategy"));

Expand Down
3 changes: 0 additions & 3 deletions gremlin-go/build/generate.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -121,9 +121,6 @@ radishGremlinFile.withWriter('UTF-8') { Writer writer ->
' traversalFn := traversalFns[0]\n' +
' translationMap[scenarioName] = traversalFns[1:]\n' +
' traversal := traversalFn(g, parameters)\n' +
' for key, value := range sideEffects {\n' +
' traversal.Bytecode.AddSource("withSideEffect", key, value)\n' +
' }\n' +
' return traversal, nil\n' +
' } else {\n' +
' return nil, errors.New("scenario for traversal not recognized")\n' +
Expand Down
2 changes: 1 addition & 1 deletion gremlin-go/driver/anonymousTraversal.go
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ type anonymousTraversal struct {

var T__ AnonymousTraversal = &anonymousTraversal{
func() *GraphTraversal {
return NewGraphTraversal(nil, NewBytecode(nil), nil)
return NewGraphTraversal(nil, NewGremlinLang(nil), nil)
},
}

Expand Down
2 changes: 1 addition & 1 deletion gremlin-go/driver/authInfo.go
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ func (d *DynamicAuth) GetHeader() http.Header {
return d.fn().GetHeader()
}

// GetHeader calls the stored function to get basic authentication dynamically.
// GetBasicAuth calls the stored function to get basic authentication dynamically.
func (d *DynamicAuth) GetBasicAuth() (bool, string, string) {
return d.fn().GetBasicAuth()
}
182 changes: 0 additions & 182 deletions gremlin-go/driver/bytecode.go

This file was deleted.

Loading
Loading