Update format string for formatting chrono duration #12684
+9
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moonchen
reviewed
Nov 21, 2025
src/iocore/eventsystem/Watchdog.cc
Outdated
| Dbg(dbg_ctl_watchdog, "Starting watchdog with timeout %" PRIu64 " ms on %zu threads. sleep_time = %" PRIu64 " us", | ||
| _timeout.count(), _threads.size(), std::chrono::duration_cast<std::chrono::microseconds>(sleep_time).count()); | ||
| Dbg(dbg_ctl_watchdog, "Starting watchdog with timeout %lld ms on %zu threads. sleep_time = %lld us", _timeout.count(), | ||
| _threads.size(), std::chrono::duration_cast<std::chrono::microseconds>(sleep_time).count()); |
Contributor
There was a problem hiding this comment.
To deal with different numeric types for std::chrono::microseconds on different systems, how about:
_threads.size(), std::chrono::duration_cast<std::chrono::duration<long long, std::micro>>(sleep_time).count());
Contributor
Author
There was a problem hiding this comment.
It does seem like different vendors/versions have different types for rep. Madness!
moonchen
reviewed
Nov 21, 2025
| if (warned_seq < seq) { | ||
| // Warn once per loop iteration | ||
| Warning("Watchdog: [ET_NET %zu] has been awake for %" PRIu64 " ms", i, | ||
| Warning("Watchdog: [ET_NET %zu] has been awake for %lld ms", i, |
Contributor
There was a problem hiding this comment.
Likewise,
std::chrono::duration_cast<std::chrono::duration<long long, std::milli>>(awake_duration).count());
bneradt
requested changes
Nov 25, 2025
src/iocore/eventsystem/Watchdog.cc
Outdated
Comment on lines
64
to
65
| std::chrono::duration_cast<std::chrono::duration<long long, std::milli>>(_timeout).count(), _threads.size(), | ||
| std::chrono::duration_cast<std::chrono::duration<long long, std::micro>>(sleep_time).count()); |
Contributor
There was a problem hiding this comment.
Looks like the compilers are happy with it. Can we put this in a using alias though?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer clang compilers want
%lldforlong longand%ldforlongand will warn otherwise. Unfortunately, there isn't a way to use thePRI*macros to producelldon 64 bit word systems.