Skip to content

Update format string for formatting chrono duration #12684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+9 −4
Open

Update format string for formatting chrono duration #12684

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c10391
Update format string for formatting chrono duration
cmcfarlen Nov 21, 2025
179bdef
normalize cast to long long
cmcfarlen Nov 24, 2025
48b767f
Alias duration case type
cmcfarlen Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/iocore/eventsystem/Watchdog.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ Monitor::monitor_loop() const
// Divide by a floating point 2 to avoid truncation to zero.
auto sleep_time = _timeout / 2.0;
ink_release_assert(sleep_time.count() > 0);
Dbg(dbg_ctl_watchdog, "Starting watchdog with timeout %" PRIu64 " ms on %zu threads. sleep_time = %" PRIu64 " us",
_timeout.count(), _threads.size(), std::chrono::duration_cast<std::chrono::microseconds>(sleep_time).count());
Dbg(dbg_ctl_watchdog, "Starting watchdog with timeout %lld ms on %zu threads. sleep_time = %lld us", _timeout.count(),
_threads.size(), std::chrono::duration_cast<std::chrono::microseconds>(sleep_time).count());
Copy link
Contributor

@moonchen moonchen Nov 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To deal with different numeric types for std::chrono::microseconds on different systems, how about:

_threads.size(), std::chrono::duration_cast<std::chrono::duration<long long, std::micro>>(sleep_time).count());

Copy link
Contributor Author

@cmcfarlen cmcfarlen Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does seem like different vendors/versions have different types for rep. Madness!


ink_set_thread_name("[WATCHDOG]");

Expand Down Expand Up @@ -90,7 +90,7 @@ Monitor::monitor_loop() const
uint64_t warned_seq = t->heartbeat_state.warned_seq.load(std::memory_order_relaxed);
if (warned_seq < seq) {
// Warn once per loop iteration
Warning("Watchdog: [ET_NET %zu] has been awake for %" PRIu64 " ms", i,
Warning("Watchdog: [ET_NET %zu] has been awake for %lld ms", i,
Copy link
Contributor

@moonchen moonchen Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise,

std::chrono::duration_cast<std::chrono::duration<long long, std::milli>>(awake_duration).count());

std::chrono::duration_cast<std::chrono::milliseconds>(awake_duration).count());
t->heartbeat_state.warned_seq.store(seq, std::memory_order_relaxed);
}
Expand Down