[Relax] Remove obsolete TODO comments

[guan404ming]

• Remove TODO about ctx->ReportWarning() since LOG(WARNING) is the standard pattern
• Remove TODO about skipping type params/constraints since the current FuncType implementation only contains arg_types and ret_type fields. type_params and type_constraints don't exist in the codebase.
• Fixed typo in warning message

[gemini-code-assist]

Summary of Changes

Hello @guan404ming, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving code hygiene by removing obsolete TODO comments and making minor textual corrections. It addresses two main points: clarifying that LOG(WARNING) is the standard logging mechanism, thus rendering a specific TODO redundant, and acknowledging that certain FuncType fields mentioned in another TODO no longer exist, thereby removing misleading comments. These changes contribute to a cleaner, more accurate codebase.

Highlights

• Obsolete TODO Removal (FuncType): Removed a TODO comment in ast_printer.py that referred to type_params and type_constraints within FuncType, as these fields do not exist in the current implementation.
• Obsolete TODO Removal (Logging Pattern): Removed a TODO comment in index.cc that questioned the equivalent of ctx->ReportFatal for warnings, confirming LOG(WARNING) as the standard and appropriate logging pattern.
• Terminology Consistency: Updated warning messages in index.cc and manipulate.cc to consistently use the term 'index' instead of 'indice'.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request is a good cleanup, removing obsolete TODO comments and fixing typos in log messages. The changes are correct and improve code quality. I have a couple of minor suggestions to further improve the clarity of the warning messages.

[cchung100m]

LGTM, thanks to @guan404ming 😄