Skip to content

[Relax] Remove obsolete TODO comments #18649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlopex merged 1 commit into from
Jan 11, 2026
+2 −4
Merged

[Relax] Remove obsolete TODO comments #18649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion python/tvm/relax/testing/ast_printer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,6 @@ def visit_type_(self, type_node: relax.Type) -> str:
"FuncType",
arg_types=self.build_list(map(self.visit_type_, type_node.arg_types)),
ret_type=self.visit_type_(type_node.ret_type),
# TODO: skipping type params and type constraints
)
raise ValueError(f"Invalid Relax Type {type_node} ({type(type_node)})")

Expand Down
3 changes: 1 addition & 2 deletions src/relax/op/tensor/index.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,7 @@ StructInfo InferStructInfoTake(const Call& call, const BlockBuilder& ctx) {
}();

if (indices_sinfo->IsUnknownDtype()) {
// TODO(tvm-team): Do we have an equivalent of `ctx->ReportFatal` for warning?
LOG(WARNING) << "Data type of indice has not been specified. Assume it has an integer type.";
LOG(WARNING) << "Data type of indices has not been specified. Assume it has an integer type.";
} else if (!(indices_sinfo->dtype.is_int() || indices_sinfo->dtype.is_uint())) {
ctx->ReportFatal(Diagnostic::Error(call)
<< "Take op requires the input indices to have integer dtype. However, the "
Expand Down
2 changes: 1 addition & 1 deletion src/relax/op/tensor/manipulate.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2617,7 +2617,7 @@ StructInfo InferStructInfoScatterElements(const Call& call, const BlockBuilder&
}

if (indices_sinfo->IsUnknownDtype()) {
LOG(WARNING) << "Data type of indice has not been specified. Assume it has an integer type.";
LOG(WARNING) << "Data type of indices has not been specified. Assume it has an integer type.";
} else if (!(indices_sinfo->dtype.is_int() || indices_sinfo->dtype.is_uint())) {
ctx->ReportFatal(
Diagnostic::Error(call)
Expand Down
Loading