Skip to content

Conversation

@vladfrangu
Copy link
Member

No description provided.

@vladfrangu vladfrangu added the adhoc Ad-hoc unplanned task added during the sprint. label Nov 12, 2024
@vladfrangu vladfrangu requested a review from janbuchar November 12, 2024 13:26
@vladfrangu vladfrangu requested a review from B4nan as a code owner November 12, 2024 13:26
@github-actions github-actions bot added this to the 102nd sprint - Tooling team milestone Nov 12, 2024
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Nov 12, 2024
- Scrapy wrapping being broken due to ESM migration ([#686](https://github.com/apify/apify-cli/pull/686)) ([e2a7591](https://github.com/apify/apify-cli/commit/e2a7591070a284394643e8dbb03bc020939ff61f)) by [@vladfrangu](https://github.com/vladfrangu)
- *(ci)* Make it work + publish with provenances ([#694](https://github.com/apify/apify-cli/pull/694)) ([e41ea72](https://github.com/apify/apify-cli/commit/e41ea728a9177dcec4ea73c25128cddebc00dd79)) by [@vladfrangu](https://github.com/vladfrangu)

- _(ci)_ Make it work + publish with provenances ([#694](https://github.com/apify/apify-cli/pull/694)) ([e41ea72](https://github.com/apify/apify-cli/commit/e41ea728a9177dcec4ea73c25128cddebc00dd79)) by [@vladfrangu](https://github.com/vladfrangu)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one should be a ci type I guess, its not relevant to users

btw our formatter dislikes bold in general? this is converting to italics, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

* is ambiguous, in most markdowns, including github's, its an alternative for italics. You use double ** for bold

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And ya, I plan on opening a PR to fix that in our workflows

@vladfrangu vladfrangu merged commit 42c6ef8 into master Nov 12, 2024
@vladfrangu vladfrangu deleted the chore/format-after-generate branch November 12, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants