Skip to content

ci: format after changelog insertion #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vladfrangu merged 2 commits into from
Nov 12, 2024
Merged

ci: format after changelog insertion #697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f0d9d4
ci: format after changelog insertion
vladfrangu Nov 12, 2024
344b322
chore: remove inaccurate changelog entry (should probably regen the w…
vladfrangu Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/pre_release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,9 @@ jobs:
write-mode: overwrite
contents: ${{ needs.release_metadata.outputs.changelog }}

- name: Format
run: yarn format:fix

- name: Commit changes
id: commit
uses: EndBug/add-and-commit@v9
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,9 @@ jobs:
write-mode: overwrite
contents: ${{ needs.release_metadata.outputs.changelog }}

- name: Format
run: yarn format:fix

- name: Commit changes
id: commit
uses: EndBug/add-and-commit@v9
Expand Down
7 changes: 3 additions & 4 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
All notable changes to this project will be documented in this file.

<!-- git-cliff-unreleased-start -->

## 0.20.8 - **not yet released**

### 🚀 Features
Expand All @@ -29,11 +30,9 @@ All notable changes to this project will be documented in this file.
- Look for lowercase input schema in default paths ([#647](https://github.com/apify/apify-cli/pull/647)) ([68456e6](https://github.com/apify/apify-cli/commit/68456e63eee3c28e7c0ee7464a2cbc1a00ba9dfa)) by [@mvolfik](https://github.com/mvolfik)
- Emit warning if input.json is modified during run and prefilled with defaults ([#672](https://github.com/apify/apify-cli/pull/672)) ([8a6fd3f](https://github.com/apify/apify-cli/commit/8a6fd3f60523380041309db830a62f52cc60e4d4)) by [@vladfrangu](https://github.com/vladfrangu), closes [#670](https://github.com/apify/apify-cli/issues/670)
- Scrapy wrapping being broken due to ESM migration ([#686](https://github.com/apify/apify-cli/pull/686)) ([e2a7591](https://github.com/apify/apify-cli/commit/e2a7591070a284394643e8dbb03bc020939ff61f)) by [@vladfrangu](https://github.com/vladfrangu)
- *(ci)* Make it work + publish with provenances ([#694](https://github.com/apify/apify-cli/pull/694)) ([e41ea72](https://github.com/apify/apify-cli/commit/e41ea728a9177dcec4ea73c25128cddebc00dd79)) by [@vladfrangu](https://github.com/vladfrangu)

- _(ci)_ Make it work + publish with provenances ([#694](https://github.com/apify/apify-cli/pull/694)) ([e41ea72](https://github.com/apify/apify-cli/commit/e41ea728a9177dcec4ea73c25128cddebc00dd79)) by [@vladfrangu](https://github.com/vladfrangu)
Copy link
Member

@B4nan B4nan Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one should be a ci type I guess, its not relevant to users

btw our formatter dislikes bold in general? this is converting to italics, right?

Copy link
Member Author

@vladfrangu vladfrangu Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

* is ambiguous, in most markdowns, including github's, its an alternative for italics. You use double ** for bold

Copy link
Member Author

@vladfrangu vladfrangu Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And ya, I plan on opening a PR to fix that in our workflows


<!-- git-cliff-unreleased-end -->
**Changelog file is no longer maintained, you can check all changes in [GitHub Releases](https://github.com/apify/apify-cli/releases).**

# 0.6.1 / 2020-05-18

Expand Down Expand Up @@ -226,4 +225,4 @@ All notable changes to this project will be documented in this file.

# 0.0.x / 2018-03-01

- Initial development, lot of new stuff
- Initial development, lot of new stuff