Skip to content

Conversation

@patrikbraborec
Copy link
Contributor

@patrikbraborec patrikbraborec commented Jul 3, 2025

  • The improvements address issues I encountered during building my first actor and setting env variables. Please take it as a suggestion open to discussion!
  • The page now contains some "duplicate" information with the page https://docs.apify.com/cli/docs/vars#set-up-environment-variables-in-apify-console. I think that is not an issue; maybe we can interlink those pages.
  • I am not completely sure about the Configuration class and how I described it, but I tried it locally and in Apify console, and it worked that way, but I just maybe do not understand it yet.

@patrikbraborec patrikbraborec requested a review from TC-MO as a code owner July 3, 2025 20:51
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Misleading Variable Assignment in Python Example

In the Python example for accessing environment variables, the variable userId is misleadingly assigned the value of os.environ['api_token']. This contradicts the variable's name and the surrounding comments, causing confusion.

sources/platform/actors/development/programming_interface/environment_variables.md#L157-L161

# get api_token
userId = os.environ['api_token']
# print api_token to console
print(userId)

Fix in CursorFix in Web


Comment bugbot run to trigger another review on this PR
Was this report helpful? Give feedback by reacting with 👍 or 👎

@apify-service-account
Copy link

Preview for this PR was built for commit ff39d100 and is ready at https://pr-1668.preview.docs.apify.com!

@apify-service-account
Copy link

Preview for this PR was built for commit f59a3f25 and is ready at https://pr-1668.preview.docs.apify.com!

@apify-service-account
Copy link

Preview for this PR was built for commit 6e113021 and is ready at https://pr-1668.preview.docs.apify.com!

Copy link
Contributor

@TC-MO TC-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did few rewrites for clarity & conciseness
rewrote notes to be more active voice to adhere to msoft style guide and general technical writing principle

@apify-service-account
Copy link

Preview for this PR was built for commit 1fe541de and is ready at https://pr-1668.preview.docs.apify.com!

@apify-service-account
Copy link

Preview for this PR was built for commit 27c720ab and is ready at https://pr-1668.preview.docs.apify.com!

@apify-service-account
Copy link

Preview for this PR was built for commit 2891771b and is ready at https://pr-1668.preview.docs.apify.com!

@apify-service-account
Copy link

Preview for this PR was built for commit c4cb588c and is ready at https://pr-1668.preview.docs.apify.com!

@apify-service-account
Copy link

Preview for this PR was built for commit f2aafda2 and is ready at https://pr-1668.preview.docs.apify.com!

Signed-off-by: Patrik Braborec <[email protected]>
@apify-service-account
Copy link

Preview for this PR was built for commit 05cc36c8 and is ready at https://pr-1668.preview.docs.apify.com!

@apify-service-account
Copy link

Preview for this PR was built for commit 3e83d6e3 and is ready at https://pr-1668.preview.docs.apify.com!

@apify-service-account
Copy link

Preview for this PR was built for commit 97fb2d09 and is ready at https://pr-1668.preview.docs.apify.com!

Signed-off-by: Patrik Braborec <[email protected]>
@apify-service-account
Copy link

Preview for this PR was built for commit 672168ec and is ready at https://pr-1668.preview.docs.apify.com!

@patrikbraborec patrikbraborec self-assigned this Jul 4, 2025
@apify-service-account
Copy link

Preview for this PR was built for commit fa1a1f67 and is ready at https://pr-1668.preview.docs.apify.com!

@TC-MO TC-MO added documentation Improvements or additions to documentation. adhoc Ad-hoc unplanned task added during the sprint. labels Jul 4, 2025
@patrikbraborec patrikbraborec force-pushed the improve-actors-env-docs branch from dd66c2e to fa1a1f6 Compare July 7, 2025 12:26
@apify-service-account
Copy link

Preview for this PR was built for commit dd66c2e8 and is ready at https://pr-1668.preview.docs.apify.com!

@apify-service-account
Copy link

Preview for this PR was built for commit 7c9e756d and is ready at https://pr-1668.preview.docs.apify.com!

Copy link
Member

@metalwarrior665 metalwarrior665 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just few small nits and good for me

Copy link

@ku3o ku3o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Patrik 👋 ,

First of all, welcome to Apify 🎉 . Great to have you here. I have only one comment

@apify-service-account
Copy link

Preview for this PR was built for commit 507b9a1b and is ready at https://pr-1668.preview.docs.apify.com!

@apify-service-account
Copy link

Preview for this PR was built for commit dfbc6b86 and is ready at https://pr-1668.preview.docs.apify.com!

Copy link
Contributor

@TC-MO TC-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patrikbraborec patrikbraborec merged commit 9c14e10 into master Jul 8, 2025
9 checks passed
@patrikbraborec patrikbraborec deleted the improve-actors-env-docs branch July 8, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. documentation Improvements or additions to documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants