-
Notifications
You must be signed in to change notification settings - Fork 141
docs: Improve Actors environment variables docs #1668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Patrik Braborec <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Misleading Variable Assignment in Python Example
In the Python example for accessing environment variables, the variable userId is misleadingly assigned the value of os.environ['api_token']. This contradicts the variable's name and the surrounding comments, causing confusion.
sources/platform/actors/development/programming_interface/environment_variables.md#L157-L161
apify-docs/sources/platform/actors/development/programming_interface/environment_variables.md
Lines 157 to 161 in ff39d10
| # get api_token | |
| userId = os.environ['api_token'] | |
| # print api_token to console | |
| print(userId) |
Comment bugbot run to trigger another review on this PR
Was this report helpful? Give feedback by reacting with 👍 or 👎
|
Preview for this PR was built for commit |
Signed-off-by: Patrik Braborec <[email protected]>
Signed-off-by: Patrik Braborec <[email protected]>
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
TC-MO
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did few rewrites for clarity & conciseness
rewrote notes to be more active voice to adhere to msoft style guide and general technical writing principle
sources/platform/actors/development/programming_interface/environment_variables.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/programming_interface/environment_variables.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/programming_interface/environment_variables.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/programming_interface/environment_variables.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/programming_interface/environment_variables.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/programming_interface/environment_variables.md
Show resolved
Hide resolved
sources/platform/actors/development/programming_interface/environment_variables.md
Outdated
Show resolved
Hide resolved
|
Preview for this PR was built for commit |
sources/platform/actors/development/programming_interface/environment_variables.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/programming_interface/environment_variables.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/programming_interface/environment_variables.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/programming_interface/environment_variables.md
Show resolved
Hide resolved
sources/platform/actors/development/programming_interface/environment_variables.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/programming_interface/environment_variables.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/programming_interface/environment_variables.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/programming_interface/environment_variables.md
Outdated
Show resolved
Hide resolved
…ronment_variables.md Co-authored-by: Michał Olender <[email protected]>
|
Preview for this PR was built for commit |
…ronment_variables.md Co-authored-by: Michał Olender <[email protected]>
…ronment_variables.md Co-authored-by: Michał Olender <[email protected]>
…ronment_variables.md Co-authored-by: Michał Olender <[email protected]>
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
…ronment_variables.md Co-authored-by: Michał Olender <[email protected]>
|
Preview for this PR was built for commit |
Signed-off-by: Patrik Braborec <[email protected]>
|
Preview for this PR was built for commit |
Signed-off-by: Patrik Braborec <[email protected]>
…ronment_variables.md Co-authored-by: Michał Olender <[email protected]>
|
Preview for this PR was built for commit |
…ronment_variables.md Co-authored-by: Michał Olender <[email protected]>
|
Preview for this PR was built for commit |
Signed-off-by: Patrik Braborec <[email protected]>
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
dd66c2e to
fa1a1f6
Compare
Signed-off-by: Patrik Braborec <[email protected]>
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
metalwarrior665
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just few small nits and good for me
sources/platform/actors/development/programming_interface/environment_variables.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/programming_interface/environment_variables.md
Show resolved
Hide resolved
ku3o
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Patrik 👋 ,
First of all, welcome to Apify 🎉 . Great to have you here. I have only one comment
sources/platform/actors/development/programming_interface/environment_variables.md
Outdated
Show resolved
Hide resolved
…ronment_variables.md Co-authored-by: Lukáš Křivka <[email protected]>
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
TC-MO
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Configurationclass and how I described it, but I tried it locally and in Apify console, and it worked that way, but I just maybe do not understand it yet.