-
Notifications
You must be signed in to change notification settings - Fork 141
fix: update Extracting lesson to be about JS #1741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Preview for this PR was built for commit |
sources/academy/webscraping/scraping_basics_javascript2/07_extracting_data.md
Outdated
Show resolved
Hide resolved
sources/academy/webscraping/scraping_basics_python/07_extracting_data.md
Outdated
Show resolved
Hide resolved
|
Preview for this PR was built for commit |
|
bugbot run |
|
Preview for this PR was built for commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment bugbot run to trigger another review on this PR
sources/academy/webscraping/scraping_basics_javascript2/07_extracting_data.md
Show resolved
Hide resolved
vdusek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Two people and a bugbot have seen this PR, so I'll merge. If you have anything to add, @TC-MO, feel free to add it as a comment and I'll address it in follow-ups. |
A part of #1584. Adding @vdusek for a review as well, because this PR contains also some changes to the original Python lesson. In reviews, I expect to get feedback on writing from Michał, on JavaScript from Marco, and on Python from Vláďa 😅