fix: Absolute URL md links #1959
Conversation
github-actions
bot
added
the
t-web
|
Preview for this PR was built for commit |
1 similar comment
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
1 similar comment
|
Preview for this PR was built for commit |
…/alternate-absolute
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
…/alternate-absolute
|
Preview for this PR was built for commit |
There was a problem hiding this comment.
When I go to https://pr-1959.preview.docs.apify.com/api.md I still see
Isn't it supposed to link to /academy.md instead of just /academy?
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Comment @cursor review or bugbot run to trigger another review on this PR
|
|
||
| const parsedUrl = parse(node.url); | ||
| const isUrlInternal = isInternal(parsedUrl, config.absoluteUrl); | ||
| const url = isUrlInternal ? `${config.absoluteUrl}${parsedUrl.pathname}.md` : node.url; |
There was a problem hiding this comment.
Bug: URL Handling and Link Classification Issues
The isInternal function receives config.absoluteUrl (a full URL) instead of just a hostname, causing all internal links to be incorrectly classified as external. Additionally, internal URLs are unconditionally appended with .md, which can break links to non-markdown resources.
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
Closes #1886
Removed invalid links: