-
Notifications
You must be signed in to change notification settings - Fork 129
fix: Absolute URL md links #1959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
HonzaTuron
wants to merge
16
commits into
master
Choose a base branch
from
fix/alternate-absolute
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+12
−9
Open
Changes from 14 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
580b338
fix: Absolute URL md links
HonzaTuron 1a49179
Merge branch 'master' into fix/alternate-absolute
HonzaTuron 78a5488
fix: Absolute URL md links
HonzaTuron 3069e64
Merge remote-tracking branch 'origin/fix/alternate-absolute' into fix…
HonzaTuron 15bfbbf
parse node url
HonzaTuron fd5936a
node startswith
HonzaTuron 0eb7db2
Merge branch 'master' into fix/alternate-absolute
HonzaTuron e34bd78
return ''
HonzaTuron 0752695
Merge remote-tracking branch 'origin/fix/alternate-absolute' into fix…
HonzaTuron c667bcb
correct pathname
HonzaTuron 8328056
clean no pathname
HonzaTuron ae0ae18
Merge branch 'master' into fix/alternate-absolute
HonzaTuron 1a069e0
no log
HonzaTuron 760331e
Merge remote-tracking branch 'origin/fix/alternate-absolute' into fix…
HonzaTuron f9e2026
feat: Add absolute url
HonzaTuron 7349b82
Add llms desc
HonzaTuron File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: URL Handling and Link Classification Issues
The
isInternal
function receivesconfig.absoluteUrl
(a full URL) instead of just a hostname, causing all internal links to be incorrectly classified as external. Additionally, internal URLs are unconditionally appended with.md
, which can break links to non-markdown resources.