feat: Experimenting with oauth #126
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
t-console
valekjo
force-pushed
the
feature/adhoc-oauth-dynamic-client-registration
branch
from
dc06389 to
3ed7b4e
Compare
valekjo
commented
May 23, 2025
Comment on lines
-19
to
-23
| export function getApifyAPIBaseUrl(): string { | ||
| // Workaround for Actor server where the platform APIFY_API_BASE_URL did not work with getActorDefinition from actors.ts | ||
| if (process.env.APIFY_IS_AT_HOME) return 'https://api.apify.com'; | ||
| return process.env.APIFY_API_BASE_URL || 'https://api.apify.com'; | ||
| } |
Member
Author
There was a problem hiding this comment.
Note: The workaround did not work when running the platform locally, and probably would not work on staging as well.
Where was the APIFY_API_BASE_URL env var missing?
Collaborator
There was a problem hiding this comment.
Great catch, this was actually a hack from @MQ37
This package is imported in apify-mcp-server where APIFY_API_BASE_URL is defined 🙈.
Here is a TODO for that https://github.com/apify/apify-mcp-server/blob/0b336190178ad85beb1ee83956924d98c0eb129b/src/main.ts#L18
I'm not sure if we'll have time to fix it this week.
Member
Author
|
Closing this one, seems it's no longer relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems that we won't need any changes related to MCP + oAuth in the Actor itself :)
But I struggled with this when running the platform locally.
Specs: https://www.notion.so/apify/Apify-as-OAuth-Provider-Docs-192f39950a22807b83a0c8fcbdac90cc