Skip to content

feat: Experimenting with oauth #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

feat: Experimenting with oauth #126

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3ed7b4e
feat: Fix for local testing of MCP
valekjo May 22, 2025
1272bf6
Put back the rag browser
valekjo May 22, 2025
5d85d9e
Test: remove default actor
valekjo May 27, 2025
5ff6373
Hardcode staging url
valekjo May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions src/apify-client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,17 +16,10 @@ function addUserAgent(config: AxiosRequestConfig): AxiosRequestConfig {
return updatedConfig;
}

export function getApifyAPIBaseUrl(): string {
// Workaround for Actor server where the platform APIFY_API_BASE_URL did not work with getActorDefinition from actors.ts
if (process.env.APIFY_IS_AT_HOME) return 'https://api.apify.com';
return process.env.APIFY_API_BASE_URL || 'https://api.apify.com';
}
Comment on lines -19 to -23
Copy link
Member Author

@valekjo valekjo May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: The workaround did not work when running the platform locally, and probably would not work on staging as well.
Where was the APIFY_API_BASE_URL env var missing?

Copy link
Collaborator

@jirispilka jirispilka May 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, this was actually a hack from @MQ37

This package is imported in apify-mcp-server where APIFY_API_BASE_URL is defined 🙈.
Here is a TODO for that https://github.com/apify/apify-mcp-server/blob/0b336190178ad85beb1ee83956924d98c0eb129b/src/main.ts#L18

I'm not sure if we'll have time to fix it this week.


export class ApifyClient extends _ApifyClient {
constructor(options: ApifyClientOptions) {
super({
...options,
baseUrl: getApifyAPIBaseUrl(),
requestInterceptors: [addUserAgent],
});
}
Expand Down
Loading