Skip to content

Conversation

@mfori
Copy link
Member

@mfori mfori commented Jan 5, 2026

This is not supported and not documented anywhere, but since we have prepared this in some places for the future, it causes issues because it allows users to pass any string: https://github.com/apify/apify-core/issues/24868

We should put it back only once we have request queue schema in place.

It could be a potential breaking change, but since it's not documented anywhere, I should be ok.

@mfori mfori requested review from Copilot and gippy January 5, 2026 09:41
@mfori mfori self-assigned this Jan 5, 2026
@mfori mfori added the t-console Issues with this label are in the ownership of the console team. label Jan 5, 2026
@github-actions github-actions bot added this to the 131st sprint - Console team milestone Jan 5, 2026
@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label Jan 5, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the undocumented and unsupported storages.requestQueue property from the actor definition schema to prevent users from passing invalid configurations. The change also adds additionalProperties: false to enforce stricter validation on the storages object.

  • Removes requestQueue property from the storages object in the actor schema
  • Adds additionalProperties: false to the storages object to prevent future issues with unsupported properties
  • Updates test cases to remove references to requestQueue in test data

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
packages/json_schemas/src/actor.schema.ts Removes the requestQueue property definition from the storages object and adds additionalProperties: false to enforce strict validation
packages/json_schemas/schemas/actor.schema.json Generated JSON schema with matching changes - removes requestQueue property and adds additionalProperties: false
test/actor_schema.test.ts Removes requestQueue references from two test cases that validate actor schemas with string and object storages configurations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

type: 'string',
},
},
additionalProperties: false,
Copy link

Copilot AI Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of additionalProperties: false to the storages object is a positive change that will prevent unknown properties from being accepted. However, there's no test case to verify that additional properties (like the now-removed requestQueue) are properly rejected. Consider adding a test in the "invalid schemas" section that attempts to use an unsupported property in the storages object and verifies that validation fails.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-console Issues with this label are in the ownership of the console team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant