Skip to content

feat(json_schemas): Remove storages.requestQueue from actor definition #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mfori wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(json_schemas): Remove storages.requestQueue from actor definition #586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions packages/json_schemas/schemas/actor.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,11 +122,9 @@
"$ref": "https://apify.com/schemas/v1/dataset.json"
}
]
},
"requestQueue": {
"type": "string"
}
}
},
"additionalProperties": false
},
"usesStandbyMode": {
"type": "boolean"
Expand Down
4 changes: 1 addition & 3 deletions packages/json_schemas/src/actor.schema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,10 +128,8 @@ export const actorSchema = {
},
],
},
requestQueue: {
type: 'string',
},
},
additionalProperties: false,
Copy link

Copilot AI Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of additionalProperties: false to the storages object is a positive change that will prevent unknown properties from being accepted. However, there's no test case to verify that additional properties (like the now-removed requestQueue) are properly rejected. Consider adding a test in the "invalid schemas" section that attempts to use an unsupported property in the storages object and verifies that validation fails.

Copilot uses AI. Check for mistakes.
},
usesStandbyMode: {
type: 'boolean',
Expand Down
2 changes: 0 additions & 2 deletions test/actor_schema.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ describe('actor.json', () => {
},
},
},
requestQueue: 'my-request-queue',
},
usesStandbyMode: true,
webServerSchema: {
Expand Down Expand Up @@ -119,7 +118,6 @@ describe('actor.json', () => {
storages: {
keyValueStore: 'key-value-store.json',
dataset: 'dataset.json',
requestQueue: 'request-queue',
},
webServerSchema: 'web-server-schema.json',
};
Expand Down