Skip to content

Conversation

@dkempner
Copy link

@dkempner dkempner commented Jul 10, 2025

Fixes #12762

@apollo-cla
Copy link

@dkempner: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@changeset-bot
Copy link

changeset-bot bot commented Jul 10, 2025

🦋 Changeset detected

Latest commit: 9a8ff8b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dkempner dkempner changed the title [SSR] batched query promise rendering SSR functions take batchOptions, to modulate query batching Jul 10, 2025
Comment on lines +42 to +43
let iterationCount = 0;
const MAX_ITERATIONS = 50; // Prevent infinite loops
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is something we might pass in to batchOptions

@dkempner dkempner changed the title SSR functions take batchOptions, to modulate query batching SSR functions take batchOptions to modulate query batching Jul 10, 2025
@phryneas
Copy link
Member

Since the logic has pretty much rewritten in 4.0 and we're probably not going to add anything to 3.x anymore (4.0 is scheduled to drop at the end of the month), could you please try to base this on the release-4.0 branch?

While this won't make it in 4.0 (we're at RC already), this could make it into a 4.1.

@dkempner
Copy link
Author

Closing in favor of #12769

@dkempner dkempner closed this Jul 11, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

renderToStringWithData/getDataFromTree unbatched

3 participants