-
Notifications
You must be signed in to change notification settings - Fork 2.7k
SSR functions take batchOptions to modulate query batching
#12767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@dkempner: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
🦋 Changeset detectedLatest commit: 9a8ff8b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| let iterationCount = 0; | ||
| const MAX_ITERATIONS = 50; // Prevent infinite loops |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is something we might pass in to batchOptions
batchOptions to modulate query batching
|
Since the logic has pretty much rewritten in 4.0 and we're probably not going to add anything to 3.x anymore (4.0 is scheduled to drop at the end of the month), could you please try to base this on the While this won't make it in 4.0 (we're at RC already), this could make it into a 4.1. |
|
Closing in favor of #12769 |
Fixes #12762