feat: Add configuration option for metric temporality #413
+53
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 6 changed, 0 removedBuild ID: 7e9c8ee53a9441f8a1925b2d URL: https://www.apollographql.com/docs/deploy-preview/7e9c8ee53a9441f8a1925b2d |
esilverm
approved these changes
Oct 3, 2025
DaleSeo
reviewed
Oct 6, 2025
alocay
reviewed
Oct 6, 2025
swcollard
force-pushed
the
metric-temporality
branch
from
12d024f to
c13bef9
Compare
DaleSeo
approved these changes
Oct 7, 2025
Include enum name Co-authored-by: Dale Seo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re: #411
One of the other features mentioned in this issue is setting the metric Temporality configuration option on the SDK. This can have implications as different vendors requires the use of Delta over the default of Cumulative. This change creates a new enum to expose that option in the configuration file and sets the Temporality on the otel sdk.
Spec: https://opentelemetry.io/docs/specs/otel/metrics/data-model/#temporality
Blogs explaining differences: https://grafana.com/blog/2023/09/26/opentelemetry-metrics-a-guide-to-delta-vs.-cumulative-temporality-trade-offs/ & https://docs.datadoghq.com/opentelemetry/guide/otlp_delta_temporality/
Ports similar change made in Apollo Router apollographql/router#3412