Implement power assertions #1384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 23, 2025
bioball
added a commit
that referenced
this pull request
Jan 6, 2026
This adds syntax highlighting of Pkl code! It adds highlighting for: * Stack frames within error messages * CLI REPL (highlights as you type, highlights error output) * Power assertions (coming in #1384) This uses the lexer for highlighting. It will highlight strings, numbers, keywords, but doesn't understand how to highlight nodes like types, function params, etc. The reason for this is because a single line of code by itself may not be grammatically valid.
HT154
approved these changes
Jan 6, 2026
Contributor
HT154
left a comment
HT154
left a comment
There was a problem hiding this comment.
Very nice!! Just a few minor things.
pkl-core/src/main/java/org/pkl/core/ast/type/VmTypeMismatchException.java
Outdated
Show resolved
Hide resolved
pkl-core/src/main/java/org/pkl/core/runtime/PowerAssertions.java
Outdated
Show resolved
Hide resolved
Contributor
stackoverflow
left a comment
stackoverflow
left a comment
There was a problem hiding this comment.
This looks great!
Just some small things and clarifications.
| } catch (ex: Exception) { | ||
| errWriter.appendLine("Error evaluating module ${moduleUri.path}:") | ||
| errWriter.write(ex.message ?: "") | ||
| errWriter.write(ex.stackTraceToString()) |
Contributor
There was a problem hiding this comment.
Is this intended to be here, or is it a debug leftover?
Member
Author
There was a problem hiding this comment.
Intentional, but this is a bugfix unrelated to this feature. I'll pull this into a separate PR
bioball
force-pushed
the
power-asserts
branch
from
9f15209 to
072eaa6
Compare
This annotates failing assertions in type constraints, and in tests with the values produced during code execution. This follows the power assertions style of reporting also found in Groovy, Kotlin, and others. * Literal values are not emitted in the value graph * Stdlib constructors of literals like `List(1, 2)` are also considered literals
Co-authored-by: Islon Scherer <[email protected]>
bioball
force-pushed
the
power-asserts
branch
from
c5f05c4 to
3d7d6c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds power assertions to Pkl!
This implements the SPICE described in apple/pkl-evolution#29
This follows the power assertions style of reporting also found in
Groovy, Kotlin, and others.
List(1, 2)are also consideredliterals
Power assertions are added to:
Power assertions are implemented as a truffle instrument to observe execution.
When an assertion fails, the instrument is created and the assertion is run again to observe facts.
This incurs runtime overhead to collect facts, but has no impact on code in the non-error case.
Samples: