Update protos file, generated files, and record a new conformance test failure.#1753
Merged
thomasvl merged 4 commits intoapple:mainfrom Feb 6, 2025
Merged
Update protos file, generated files, and record a new conformance test failure.#1753thomasvl merged 4 commits intoapple:mainfrom
thomasvl merged 4 commits intoapple:mainfrom
Conversation
Using upstream cab65df75ed1b1e7a3e76b63fbae5deea228ac9f.
Upstream has revised some handing of non canonical form MessageSet encoding. Not all upstream languages pass it yet, but it looks like upb is getting a check to support it, so we'll want to eventually do the work to match, but documenting the failure for now.
allevato
approved these changes
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.