expose iterators and add utilities to OrderedMap/BigOrderedMap #17441

igor-aptos · 2025-08-29T16:42:00Z

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

Which Components or Systems Does This Change Impact?

Checklist

I have read and followed the CONTRIBUTING doc
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I identified and added all stakeholders and component owners affected by this change as reviewers
I tested both happy and unhappy path of the functionality
I have made corresponding changes to the documentation

wrwg · 2025-09-15T04:10:19Z

aptos-move/framework/aptos-framework/sources/datastructures/big_ordered_map.move

-
-    // TODO: Temporary friend implementaiton, until for_each_ref can be made efficient.
-    public(friend) inline fun for_each_ref_friend<K: drop + copy + store, V: store>(self: &BigOrderedMap<K, V>, f: |&K, &V|) {
        let iter = self.new_begin_iter();


Unrelated to the PR, but loving that inlline functions allow us to hide that we can't capture a reference to the collection.

igor-aptos · 2025-10-09T22:09:28Z

expose iterators and add utilities to OrderedMap/BigOrderedMap #17441 : 2 dependent PRs (#17821 , #17829 ) 👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2025-10-09T23:34:23Z

✅ Forge suite `compat` success on `e4635b4614ac9cd5e6bcfbfa37fc3d21d28c71b9` ==> `19940e03914001fd5987dc9d7098f997c1a19d84`

Compatibility test results for e4635b4614ac9cd5e6bcfbfa37fc3d21d28c71b9 ==> 19940e03914001fd5987dc9d7098f997c1a19d84 (PR)
1. Check liveness of validators at old version: e4635b4614ac9cd5e6bcfbfa37fc3d21d28c71b9
compatibility::simple-validator-upgrade::liveness-check : committed: 14124.58 txn/s, latency: 2452.12 ms, (p50: 2500 ms, p70: 2700, p90: 2800 ms, p99: 3900 ms), latency samples: 460820
2. Upgrading first Validator to new version: 19940e03914001fd5987dc9d7098f997c1a19d84
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 5130.77 txn/s, latency: 6714.55 ms, (p50: 7500 ms, p70: 7500, p90: 7600 ms, p99: 7600 ms), latency samples: 179600
3. Upgrading rest of first batch to new version: 19940e03914001fd5987dc9d7098f997c1a19d84
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 5198.99 txn/s, latency: 6624.40 ms, (p50: 7400 ms, p70: 7500, p90: 7500 ms, p99: 7700 ms), latency samples: 180400
4. upgrading second batch to new version: 19940e03914001fd5987dc9d7098f997c1a19d84
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 8087.24 txn/s, latency: 4215.16 ms, (p50: 4600 ms, p70: 4700, p90: 4800 ms, p99: 4900 ms), latency samples: 271600
5. check swarm health
Compatibility test for e4635b4614ac9cd5e6bcfbfa37fc3d21d28c71b9 ==> 19940e03914001fd5987dc9d7098f997c1a19d84 passed
Test Ok

github-actions · 2025-10-09T23:36:57Z

✅ Forge suite `realistic_env_max_load` success on `19940e03914001fd5987dc9d7098f997c1a19d84`

two traffics test: inner traffic : committed: 13508.81 txn/s, latency: 2800.52 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 5400 ms), latency samples: 5136320
two traffics test : committed: 99.96 txn/s, latency: 765.62 ms, (p50: 700 ms, p70: 800, p90: 900 ms, p99: 1200 ms), latency samples: 1740
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.276, avg: 2.140", "ConsensusProposalToOrdered: max: 0.165, avg: 0.163", "ConsensusOrderedToCommit: max: 0.109, avg: 0.085", "ConsensusProposalToCommit: max: 0.274, avg: 0.248"]
Max non-epoch-change gap was: 2 rounds at version 1845993 (avg 0.00) [limit 4], 2.28s no progress at version 1845993 (avg 0.07s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.35s no progress at version 2418924 (avg 0.35s) [limit 16].
Test Ok

github-actions · 2025-10-09T23:40:57Z

✅ Forge suite `framework_upgrade` success on `e4635b4614ac9cd5e6bcfbfa37fc3d21d28c71b9` ==> `19940e03914001fd5987dc9d7098f997c1a19d84`

Compatibility test results for e4635b4614ac9cd5e6bcfbfa37fc3d21d28c71b9 ==> 19940e03914001fd5987dc9d7098f997c1a19d84 (PR)
Upgrade the nodes to version: 19940e03914001fd5987dc9d7098f997c1a19d84
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 2097.25 txn/s, submitted: 2105.62 txn/s, failed submission: 8.37 txn/s, expired: 8.37 txn/s, latency: 1384.47 ms, (p50: 1200 ms, p70: 1500, p90: 1800 ms, p99: 2700 ms), latency samples: 190544
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 2026.15 txn/s, submitted: 2032.30 txn/s, failed submission: 6.15 txn/s, expired: 6.15 txn/s, latency: 1436.57 ms, (p50: 1500 ms, p70: 1500, p90: 1800 ms, p99: 2300 ms), latency samples: 184540
5. check swarm health
Compatibility test for e4635b4614ac9cd5e6bcfbfa37fc3d21d28c71b9 ==> 19940e03914001fd5987dc9d7098f997c1a19d84 passed
Upgrade the remaining nodes to version: 19940e03914001fd5987dc9d7098f997c1a19d84
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 2065.24 txn/s, submitted: 2072.53 txn/s, failed submission: 7.29 txn/s, expired: 7.29 txn/s, latency: 1436.89 ms, (p50: 1400 ms, p70: 1500, p90: 1800 ms, p99: 3000 ms), latency samples: 186920
Test Ok

igor-aptos requested review from grao1991, runtian-zhou, sitalkedia, vusirikala and wrwg August 29, 2025 16:42

igor-aptos requested a review from davidiw as a code owner August 29, 2025 16:42

igor-aptos force-pushed the igor/expose_iterators_and_utilities branch 3 times, most recently from b8d5cb6 to 53e5cb4 Compare September 8, 2025 16:16

wrwg approved these changes Sep 15, 2025

View reviewed changes

vusirikala approved these changes Sep 22, 2025

View reviewed changes

vusirikala enabled auto-merge (squash) September 22, 2025 22:30

vusirikala force-pushed the igor/expose_iterators_and_utilities branch from 53e5cb4 to d203e6f Compare September 22, 2025 22:39