Adding utilities to avoid using iterators directly in BigOrderedMap/OrderedMap

[igor-aptos]

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

• New feature
• Bug fix
• Breaking change
• Performance improvement
• Refactoring
• Dependency update
• Documentation update
• Tests

Which Components or Systems Does This Change Impact?

• Validator Node
• Full Node (API, Indexer, etc.)
• Move/Aptos Virtual Machine
• Aptos Framework
• Aptos CLI/SDK
• Developer Infrastructure
• Move Compiler
• Other (specify)

Checklist

• I have read and followed the CONTRIBUTING doc
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I identified and added all stakeholders and component owners affected by this change as reviewers
• I tested both happy and unhappy path of the functionality
• I have made corresponding changes to the documentation

[manudhundi]

Are you sure this can be set to true ?
If so, as part of this PR ?

[igor-aptos]

you are right, updated.

[igor-aptos]

• Adding utilities to avoid using iterators directly in BigOrderedMap/OrderedMap #17821 : 2 dependent PRs (#17823 , #17843 ) 👈 (View in Graphite)
• expose iterators and add utilities to OrderedMap/BigOrderedMap #17441 : 1 other dependent PR (#17829 )
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

✅ Forge suite compat success on 75cc050c2c35782fc994c2a7e61a7fb3ea88f71f ==> 1bb80ccdb0a0e87b2535f8d18e60eb32b599972b

Compatibility test results for 75cc050c2c35782fc994c2a7e61a7fb3ea88f71f ==> 1bb80ccdb0a0e87b2535f8d18e60eb32b599972b (PR)
1. Check liveness of validators at old version: 75cc050c2c35782fc994c2a7e61a7fb3ea88f71f
compatibility::simple-validator-upgrade::liveness-check : committed: 14288.79 txn/s, latency: 2419.10 ms, (p50: 2500 ms, p70: 2700, p90: 2800 ms, p99: 3700 ms), latency samples: 465160
2. Upgrading first Validator to new version: 1bb80ccdb0a0e87b2535f8d18e60eb32b599972b
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 5208.03 txn/s, latency: 6620.63 ms, (p50: 7400 ms, p70: 7500, p90: 7500 ms, p99: 7600 ms), latency samples: 180520
3. Upgrading rest of first batch to new version: 1bb80ccdb0a0e87b2535f8d18e60eb32b599972b
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 5259.10 txn/s, latency: 6554.42 ms, (p50: 7300 ms, p70: 7300, p90: 7400 ms, p99: 7500 ms), latency samples: 181160
4. upgrading second batch to new version: 1bb80ccdb0a0e87b2535f8d18e60eb32b599972b
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 8266.64 txn/s, latency: 4116.64 ms, (p50: 4500 ms, p70: 4600, p90: 4700 ms, p99: 4800 ms), latency samples: 274620
5. check swarm health
Compatibility test for 75cc050c2c35782fc994c2a7e61a7fb3ea88f71f ==> 1bb80ccdb0a0e87b2535f8d18e60eb32b599972b passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite realistic_env_max_load success on 1bb80ccdb0a0e87b2535f8d18e60eb32b599972b

two traffics test: inner traffic : committed: 13708.89 txn/s, latency: 2747.00 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3900 ms), latency samples: 5212440
two traffics test : committed: 99.97 txn/s, latency: 812.53 ms, (p50: 800 ms, p70: 800, p90: 900 ms, p99: 1300 ms), latency samples: 1800
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.286, avg: 2.098", "ConsensusProposalToOrdered: max: 0.165, avg: 0.163", "ConsensusOrderedToCommit: max: 0.137, avg: 0.098", "ConsensusProposalToCommit: max: 0.302, avg: 0.261"]
Max non-epoch-change gap was: 2 rounds at version 4702331 (avg 0.00) [limit 4], 2.21s no progress at version 4702331 (avg 0.07s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.28s no progress at version 2463513 (avg 0.28s) [limit 16].
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite framework_upgrade success on 75cc050c2c35782fc994c2a7e61a7fb3ea88f71f ==> 1bb80ccdb0a0e87b2535f8d18e60eb32b599972b

Compatibility test results for 75cc050c2c35782fc994c2a7e61a7fb3ea88f71f ==> 1bb80ccdb0a0e87b2535f8d18e60eb32b599972b (PR)
Upgrade the nodes to version: 1bb80ccdb0a0e87b2535f8d18e60eb32b599972b
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 2042.69 txn/s, submitted: 2050.58 txn/s, failed submission: 7.89 txn/s, expired: 7.89 txn/s, latency: 1415.38 ms, (p50: 1500 ms, p70: 1500, p90: 1800 ms, p99: 2800 ms), latency samples: 186521
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 2084.22 txn/s, submitted: 2090.84 txn/s, failed submission: 6.62 txn/s, expired: 6.62 txn/s, latency: 1441.05 ms, (p50: 1500 ms, p70: 1500, p90: 1800 ms, p99: 2400 ms), latency samples: 188781
5. check swarm health
Compatibility test for 75cc050c2c35782fc994c2a7e61a7fb3ea88f71f ==> 1bb80ccdb0a0e87b2535f8d18e60eb32b599972b passed
Upgrade the remaining nodes to version: 1bb80ccdb0a0e87b2535f8d18e60eb32b599972b
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 2150.44 txn/s, submitted: 2158.36 txn/s, failed submission: 7.91 txn/s, expired: 7.91 txn/s, latency: 1368.81 ms, (p50: 1400 ms, p70: 1500, p90: 1600 ms, p99: 1800 ms), latency samples: 195680
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking