-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[Hot State] Use config to replace hard-coded parameters #18366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 21, 2025
Closed
4a9b661 to
22217c7
Compare
This was referenced Dec 23, 2025
09a5a5e to
995e216
Compare
grao1991
approved these changes
Jan 5, 2026
zekun000
approved these changes
Jan 7, 2026
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
✅ Forge suite
|
Contributor
✅ Forge suite
|
Contributor
✅ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Makes hot state sizing configurable via node config instead of hard-coded defaults.
HotStateConfigtoconfig/src/config/storage_config.rsand wires it intoStorageConfig(defaultmax_items_per_shard = 250_000)HotStateConfigand related constants fromtypes/src/state_store/hot_state.rs; keeps onlyLRUEntryandTHotStateSlotHotStateConfigfromaptos-config; adjusts constructors and tests accordinglyaptos-configdependency to affected cratesWritten by Cursor Bugbot for commit f450195. This will update automatically on new commits. Configure here.