Skip to content

Conversation

@wqfish
Copy link
Contributor

@wqfish wqfish commented Dec 21, 2025

Note

Makes hot state sizing configurable via node config instead of hard-coded defaults.

  • Adds HotStateConfig to config/src/config/storage_config.rs and wires it into StorageConfig (default max_items_per_shard = 250_000)
  • Removes HotStateConfig and related constants from types/src/state_store/hot_state.rs; keeps only LRUEntry and THotStateSlot
  • Updates executor, storage-interface, and aptosdb to import HotStateConfig from aptos-config; adjusts constructors and tests accordingly
  • Adds aptos-config dependency to affected crates

Written by Cursor Bugbot for commit f450195. This will update automatically on new commits. Configure here.

@wqfish wqfish changed the title [Hot State] Use config [Hot State] Use config to replace hard-coded parameters Dec 23, 2025
@wqfish wqfish force-pushed the pr18366 branch 3 times, most recently from 4a9b661 to 22217c7 Compare December 23, 2025 21:22
@wqfish wqfish marked this pull request as ready for review December 23, 2025 21:23
@wqfish wqfish requested a review from zekun000 December 23, 2025 21:23
@wqfish wqfish enabled auto-merge (rebase) January 7, 2026 19:43
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

✅ Forge suite compat success on a09bb94430a970de7bc45fe0d29bd33fd2e5a7d4 ==> f45019569482a62d954f963df65faa8292e4b4fb

Compatibility test results for a09bb94430a970de7bc45fe0d29bd33fd2e5a7d4 ==> f45019569482a62d954f963df65faa8292e4b4fb (PR)
1. Check liveness of validators at old version: a09bb94430a970de7bc45fe0d29bd33fd2e5a7d4
compatibility::simple-validator-upgrade::liveness-check : committed: 13573.03 txn/s, latency: 2563.89 ms, (p50: 2700 ms, p70: 2800, p90: 3100 ms, p99: 3600 ms), latency samples: 445620
2. Upgrading first Validator to new version: f45019569482a62d954f963df65faa8292e4b4fb
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6000.86 txn/s, latency: 5647.14 ms, (p50: 6300 ms, p70: 6300, p90: 6400 ms, p99: 6600 ms), latency samples: 207140
3. Upgrading rest of first batch to new version: f45019569482a62d954f963df65faa8292e4b4fb
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6104.79 txn/s, latency: 5537.99 ms, (p50: 6200 ms, p70: 6300, p90: 6300 ms, p99: 6400 ms), latency samples: 210720
4. upgrading second batch to new version: f45019569482a62d954f963df65faa8292e4b4fb
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 7452.36 txn/s, latency: 4174.60 ms, (p50: 3300 ms, p70: 3500, p90: 10600 ms, p99: 12700 ms), latency samples: 242300
5. check swarm health
Compatibility test for a09bb94430a970de7bc45fe0d29bd33fd2e5a7d4 ==> f45019569482a62d954f963df65faa8292e4b4fb passed
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

✅ Forge suite framework_upgrade success on a09bb94430a970de7bc45fe0d29bd33fd2e5a7d4 ==> f45019569482a62d954f963df65faa8292e4b4fb

Compatibility test results for a09bb94430a970de7bc45fe0d29bd33fd2e5a7d4 ==> f45019569482a62d954f963df65faa8292e4b4fb (PR)
Upgrade the nodes to version: f45019569482a62d954f963df65faa8292e4b4fb
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 2110.14 txn/s, submitted: 2116.33 txn/s, failed submission: 6.19 txn/s, expired: 6.19 txn/s, latency: 1407.51 ms, (p50: 1300 ms, p70: 1500, p90: 1800 ms, p99: 2800 ms), latency samples: 190800
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 2160.43 txn/s, submitted: 2168.77 txn/s, failed submission: 8.34 txn/s, expired: 8.34 txn/s, latency: 1327.89 ms, (p50: 1200 ms, p70: 1500, p90: 1800 ms, p99: 2700 ms), latency samples: 196920
5. check swarm health
Compatibility test for a09bb94430a970de7bc45fe0d29bd33fd2e5a7d4 ==> f45019569482a62d954f963df65faa8292e4b4fb passed
Upgrade the remaining nodes to version: f45019569482a62d954f963df65faa8292e4b4fb
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 2115.01 txn/s, submitted: 2122.33 txn/s, failed submission: 7.32 txn/s, expired: 7.32 txn/s, latency: 1737.67 ms, (p50: 1200 ms, p70: 1500, p90: 1500 ms, p99: 11500 ms), latency samples: 184885
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

✅ Forge suite realistic_env_max_load success on f45019569482a62d954f963df65faa8292e4b4fb

two traffics test: inner traffic : committed: 13596.07 txn/s, submitted: 13596.50 txn/s, expired: 0.43 txn/s, latency: 2768.54 ms, (p50: 2700 ms, p70: 2900, p90: 3000 ms, p99: 3600 ms), latency samples: 5061580
two traffics test : committed: 99.99 txn/s, latency: 708.95 ms, (p50: 700 ms, p70: 700, p90: 800 ms, p99: 900 ms), latency samples: 1700
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.299, avg: 2.194", "ConsensusProposalToOrdered: max: 0.168, avg: 0.165", "ConsensusOrderedToCommit: max: 0.041, avg: 0.038", "ConsensusProposalToCommit: max: 0.208, avg: 0.203"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.46s no progress at version 1414225 (avg 0.07s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.31s no progress at version 2181831 (avg 0.31s) [limit 16].
Test Ok

@wqfish wqfish merged commit fd789ba into main Jan 7, 2026
137 of 158 checks passed
@wqfish wqfish deleted the pr18366 branch January 7, 2026 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants