Skip to content

Conversation

@wqfish
Copy link
Contributor

@wqfish wqfish commented Jan 1, 2026

These error messages use a plain string literal which won't print the variables in them.


Note

Ensures path variables are interpolated in storage config validation errors.

  • Replaces plain string literals with format!(...) in StorageConfig::sanitize for ledger_db_path and metadata_path checks under db_path_overrides in storage_config.rs

Written by Cursor Bugbot for commit fa9abf0. This will update automatically on new commits. Configure here.

These error messages use a plain string literal which won't print the variables in them.
@wqfish wqfish enabled auto-merge (rebase) January 7, 2026 22:58
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

✅ Forge suite compat success on a09bb94430a970de7bc45fe0d29bd33fd2e5a7d4 ==> fa9abf0549a757f4137d81d5911b370373b08f76

Compatibility test results for a09bb94430a970de7bc45fe0d29bd33fd2e5a7d4 ==> fa9abf0549a757f4137d81d5911b370373b08f76 (PR)
1. Check liveness of validators at old version: a09bb94430a970de7bc45fe0d29bd33fd2e5a7d4
compatibility::simple-validator-upgrade::liveness-check : committed: 13510.18 txn/s, latency: 2578.94 ms, (p50: 2700 ms, p70: 2800, p90: 3300 ms, p99: 3900 ms), latency samples: 443640
2. Upgrading first Validator to new version: fa9abf0549a757f4137d81d5911b370373b08f76
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6033.57 txn/s, latency: 5596.09 ms, (p50: 6200 ms, p70: 6300, p90: 6400 ms, p99: 6600 ms), latency samples: 207920
3. Upgrading rest of first batch to new version: fa9abf0549a757f4137d81d5911b370373b08f76
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6014.09 txn/s, latency: 5620.00 ms, (p50: 6200 ms, p70: 6300, p90: 6400 ms, p99: 6500 ms), latency samples: 208240
4. upgrading second batch to new version: fa9abf0549a757f4137d81d5911b370373b08f76
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10258.96 txn/s, latency: 3266.52 ms, (p50: 3500 ms, p70: 3600, p90: 3800 ms, p99: 3900 ms), latency samples: 334420
5. check swarm health
Compatibility test for a09bb94430a970de7bc45fe0d29bd33fd2e5a7d4 ==> fa9abf0549a757f4137d81d5911b370373b08f76 passed
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

✅ Forge suite realistic_env_max_load success on fa9abf0549a757f4137d81d5911b370373b08f76

two traffics test: inner traffic : committed: 13805.29 txn/s, submitted: 13805.56 txn/s, expired: 0.27 txn/s, latency: 2726.78 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3600 ms), latency samples: 5142400
two traffics test : committed: 100.01 txn/s, latency: 702.43 ms, (p50: 700 ms, p70: 700, p90: 800 ms, p99: 900 ms), latency samples: 1640
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.238, avg: 2.163", "ConsensusProposalToOrdered: max: 0.168, avg: 0.166", "ConsensusOrderedToCommit: max: 0.040, avg: 0.037", "ConsensusProposalToCommit: max: 0.208, avg: 0.203"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.73s no progress at version 3514784 (avg 0.07s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.27s no progress at version 2076440 (avg 0.27s) [limit 16].
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

✅ Forge suite framework_upgrade success on a09bb94430a970de7bc45fe0d29bd33fd2e5a7d4 ==> fa9abf0549a757f4137d81d5911b370373b08f76

Compatibility test results for a09bb94430a970de7bc45fe0d29bd33fd2e5a7d4 ==> fa9abf0549a757f4137d81d5911b370373b08f76 (PR)
Upgrade the nodes to version: fa9abf0549a757f4137d81d5911b370373b08f76
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 2319.26 txn/s, submitted: 2326.83 txn/s, failed submission: 7.58 txn/s, expired: 7.58 txn/s, latency: 1269.95 ms, (p50: 1200 ms, p70: 1300, p90: 1800 ms, p99: 2400 ms), latency samples: 208080
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 2193.73 txn/s, submitted: 2202.12 txn/s, failed submission: 8.39 txn/s, expired: 8.39 txn/s, latency: 1341.49 ms, (p50: 1200 ms, p70: 1500, p90: 1800 ms, p99: 2700 ms), latency samples: 198740
5. check swarm health
Compatibility test for a09bb94430a970de7bc45fe0d29bd33fd2e5a7d4 ==> fa9abf0549a757f4137d81d5911b370373b08f76 passed
Upgrade the remaining nodes to version: fa9abf0549a757f4137d81d5911b370373b08f76
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 2193.18 txn/s, submitted: 2200.65 txn/s, failed submission: 7.47 txn/s, expired: 7.47 txn/s, latency: 1314.75 ms, (p50: 1200 ms, p70: 1500, p90: 1800 ms, p99: 2700 ms), latency samples: 199760
Test Ok

@wqfish wqfish merged commit f0f8fc9 into main Jan 7, 2026
111 of 119 checks passed
@wqfish wqfish deleted the pr18397 branch January 7, 2026 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants