Skip to content

Conversation

@fgfm999
Copy link
Contributor

@fgfm999 fgfm999 commented Dec 22, 2025

Description

Register appropriate file descriptor set for reflection depending on use_data_service_interface.

How Has This Been Tested?

Mannuly.

grpcurl -plaintext 127.0.0.1:50051 list

When use_data_service_interface set to true

aptos.indexer.v1.DataService
aptos.indexer.v1.GrpcManager
aptos.indexer.v1.RawData
grpc.reflection.v1.ServerReflection

When set to false

aptos.internal.fullnode.v1.FullnodeData
grpc.reflection.v1.ServerReflection

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Note

Conditionally register INDEXER_V1_FILE_DESCRIPTOR_SET or FULLNODE_V1_FILE_DESCRIPTOR_SET for gRPC reflection in runtime.rs based on use_data_service_interface.

  • Indexer gRPC Fullnode Runtime (runtime.rs):
    • Reflection: Use use_data_service_interface to choose descriptor set for reflection, registering INDEXER_V1_FILE_DESCRIPTOR_SET when true, otherwise FULLNODE_V1_FILE_DESCRIPTOR_SET.
    • Imports: Add FULLNODE_V1_FILE_DESCRIPTOR_SET to support the conditional registration.

Written by Cursor Bugbot for commit 885a184. This will update automatically on new commits. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant