Skip to content

Fix reflection service to use the right file descriptor set based on … #18371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fgfm999 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix reflection service to use the right file descriptor set based on … #18371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions ecosystem/indexer-grpc/indexer-grpc-fullnode/src/runtime.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,10 @@ use aptos_protos::{
indexer::v1::{
raw_data_server::RawDataServer, FILE_DESCRIPTOR_SET as INDEXER_V1_FILE_DESCRIPTOR_SET,
},
internal::fullnode::v1::fullnode_data_server::FullnodeDataServer,
internal::fullnode::v1::{
fullnode_data_server::FullnodeDataServer,
FILE_DESCRIPTOR_SET as FULLNODE_V1_FILE_DESCRIPTOR_SET,
},
transaction::v1::FILE_DESCRIPTOR_SET as TRANSACTION_V1_TESTING_FILE_DESCRIPTOR_SET,
util::timestamp::FILE_DESCRIPTOR_SET as UTIL_TIMESTAMP_FILE_DESCRIPTOR_SET,
};
Expand Down Expand Up @@ -84,13 +87,19 @@ pub fn bootstrap(
};
let localnet_data_server = LocalnetDataService { service_context };

let data_server_descriptor_set = if use_data_service_interface {
INDEXER_V1_FILE_DESCRIPTOR_SET
} else {
FULLNODE_V1_FILE_DESCRIPTOR_SET
};

let reflection_service = tonic_reflection::server::Builder::configure()
// Note: It is critical that the file descriptor set is registered for every
// file that the top level API proto depends on recursively. If you don't,
// compilation will still succeed but reflection will fail at runtime.
//
// TODO: Add a test for this / something in build.rs, this is a big footgun.
.register_encoded_file_descriptor_set(INDEXER_V1_FILE_DESCRIPTOR_SET)
.register_encoded_file_descriptor_set(data_server_descriptor_set)
.register_encoded_file_descriptor_set(TRANSACTION_V1_TESTING_FILE_DESCRIPTOR_SET)
.register_encoded_file_descriptor_set(UTIL_TIMESTAMP_FILE_DESCRIPTOR_SET)
.build_v1()
Expand Down
Loading