Skip to content

fix: remove incidental clipboard controls - #1377

Merged
evanaronson merged 1 commit into
mainfrom
agent/clipboard-cleanup
Sep 10, 2026
Merged

fix: remove incidental clipboard controls#1377
evanaronson merged 1 commit into
mainfrom
agent/clipboard-cleanup

Conversation

@evanaronson

Copy link
Copy Markdown
Contributor

Description

Follow-up to #1345. Remove incidental clipboard controls from token amount inputs, Alchemix voting summaries, gauge action and allocation rows, SPP body summaries, and contract-upgrade reviews. Copy availability stays consistent whether a name resolves or the address is displayed.

External-body name details keep their links, while copying remains available on the separate address row. Update the existing SPP settings test to verify that distinction and include an app patch changeset.

This contains nine app implementation files, one existing test update, and one changeset. No temporary files, dependency changes, or UI-kit edits are included. DAO-directory cards, transaction-executor summaries, and proposal-publisher bylines remain pending because their UI-kit composites do not expose a copy setting to the app.

Verification

  • Three relevant Jest suites passed: 32 tests, using the published UI kit 2.11.3.
  • Type-check passed across all four workspaces.
  • Biome passed across all four workspaces, with no fixes applied.
  • Changeset validation and whitespace checks passed.
  • The full pre-push command (pnpm turbo lint type-check test:changed) was run with Git Bash on Windows: 389 app suites / 2,558 tests passed; three suites failed to load (navigationDao, layoutRoot, providers) because of an existing SVG-transformer failure: Invalid hexadecimal escape sequence in an imported xmaquina SVG. The transformer is identical to main, and its generated code reproduces the same failure independently of these changes. After recording this failure, the local hook was bypassed for the draft push only. CI and test configuration are unchanged. Browser smoke testing and CI review remain pending.

Type of Change

  • Patch: Bug fix (non-breaking change which fixes an issue)

Developer Checklist:

  • Manually smoke tested the functionality in a preview or locally
  • Confirmed there are no new warnings or errors in the browser console
  • (For User Stories only) Double-checked that all Acceptance Criteria are satisfied
  • Confirmed there are no new warnings on automated tests
  • Merged and published any dependent changes in downstream modules
  • Selected the correct base branch
  • Commented the code in hard-to-understand areas
  • Followed the code style guidelines of this project
  • Reviewed that the Files Changed in Github's UI reflect my intended changes
  • Confirmed the pipeline checks are not failing

Review Checklist:

  • (For User Stories only) Tested in a preview or locally that all Acceptance Criteria are satisfied
  • Confirmed that changes follow the code style guidelines of this project

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

🚀 Preview Deployment: View Here

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

E2E results (preview)

Smoke

Base URL https://app-next-ogfqj3rwe-aragon-app.vercel.app
Suite smoke
Playwright result ✅ passed
Summary 82 passed
HTML report View report
GitHub job ✅ completed

View run #5149

@evanaronson
evanaronson marked this pull request as ready for review September 8, 2026 16:20
@evanaronson
evanaronson requested a review from a team as a code owner September 8, 2026 16:20
@evanaronson evanaronson changed the title fix(app): remove incidental clipboard controls fix: remove incidental clipboard controls Sep 8, 2026

@thekidnamedkd thekidnamedkd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🧹

@evanaronson
evanaronson merged commit c0d9963 into main Sep 10, 2026
20 checks passed
@evanaronson
evanaronson deleted the agent/clipboard-cleanup branch September 10, 2026 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants