fix: remove incidental clipboard controls

.changeset/quiet-clipboard-controls.md

@@ -0,0 +1,5 @@
+---
+'@aragon/app': patch
+---
+
+Remove incidental clipboard controls from token amount fields, voting summaries, gauge action rows and contract-upgrade reviews. Keep copying on dedicated address rows and remove duplicate copy controls from external-body name details.

apps/app/src/actions/gaugeRegistrar/components/gaugeRegistrarGaugeListItem/gaugeRegistrarGaugeListItem.tsx

@@ -55,7 +55,10 @@ export const GaugeRegistrarGaugeListItem: React.FC<
                     <div className="flex flex-col gap-1 font-normal leading-tight">
                         <p className="text-lg text-neutral-800">{gauge.name}</p>
                         <p className="text-neutral-500 text-sm">
-                            <AddressOutput address={gauge.gaugeAddress} />
+                            <AddressOutput
+                                address={gauge.gaugeAddress}
+                                copy={false}
+                            />
                         </p>
                     </div>
                 </div>

apps/app/src/actions/gaugeVoter/components/gaugeVoterGaugeListItem/gaugeVoterGaugeListItem.tsx

@@ -55,7 +55,10 @@ export const GaugeVoterGaugeListItem: React.FC<
                     <div className="flex flex-col gap-1 font-normal leading-tight">
                         <p className="text-lg text-neutral-800">{gauge.name}</p>
                         <p className="text-neutral-500 text-sm">
-                            <AddressOutput address={gauge.address} />
+                            <AddressOutput
+                                address={gauge.address}
+                                copy={false}
+                            />
                         </p>
                     </div>
                 </div>

apps/app/src/daos/alchemix/components/alchemixSubmitVote/alchemixSubmitVote.tsx

@@ -296,6 +296,7 @@ export const AlchemixSubmitVote: React.FC<IAlchemixSubmitVoteProps> = (
                         {delegatee != null && (
                             <AddressOutput
                                 address={delegatee}
+                                copy={false}
                                 label={delegateeEnsName ?? undefined}
                             />
                         )}
@@ -342,6 +343,7 @@ export const AlchemixSubmitVote: React.FC<IAlchemixSubmitVoteProps> = (
                                 {address != null && (
                                     <AddressOutput
                                         address={address}
+                                        copy={false}
                                         label={userEnsName ?? undefined}
                                     />
                                 )}

apps/app/src/modules/createDao/components/createProcessForm/createProcessFormGovernance/fields/governanceBodyField/governanceBodiesFieldItemDefault.tsx

@@ -53,11 +53,7 @@ export const GovernanceBodiesFieldItemDefault: React.FC<
             />
             {ensName != null && (
                 <DefinitionList.Item
-                    copyValue={body.address}
-                    link={{
-                        href: bodyAddressLink,
-                        isOnchainEntity: true,
-                    }}
+                    link={{ href: bodyAddressLink }}
                     term={t(
                         'app.createDao.createProcessForm.governance.bodyField.default.ens',
                     )}

apps/app/src/modules/finance/components/assetInput/assetInputToken.tsx

@@ -25,6 +25,7 @@ export const AssetInputToken: React.FC<IAssetInputTokenProps> = (props) => {
             {token ? (
                 <AddressOutput
                     address={token.address}
+                    copy={false}
                     label={token.symbol || undefined}
                 />
             ) : (

apps/app/src/modules/settings/dialogs/updateDaoContractsListDialog/updateDaoContractsCard.tsx

@@ -56,6 +56,7 @@ export const UpdateDaoContractsCard: React.FC<IUpdateDaoContractsCardProps> = (
                     <AddressOutput
                         address={address}
                         className="text-base text-neutral-500 md:text-lg"
+                        copy={false}
                     />
                 </div>
                 <p className="text-neutral-500 text-sm md:text-base">

apps/app/src/plugins/gaugeVoterPlugin/dialogs/gaugeVoterVoteDialog/gaugeVoterVoteDialogItem/gaugeVoterVoteDialogItem.tsx

@@ -108,7 +108,7 @@ export const GaugeVoterVoteDialogItem: React.FC<
                         />
                     </span>
                     <span className="truncate text-neutral-500 text-sm">
-                        <AddressOutput address={gaugeAddress} />
+                        <AddressOutput address={gaugeAddress} copy={false} />
                     </span>
                 </div>
             </div>

apps/app/src/plugins/sppPlugin/components/sppVotingTerminal/components/sppVotingTerminalMultiBodySummaryDefault.tsx

@@ -44,7 +44,11 @@ export const SppVotingTerminalMultiBodySummaryDefault: React.FC<
 
     return (
         <p className="font-normal text-base text-neutral-800 leading-tight md:text-lg">
-            <AddressOutput address={body} label={ensName ?? undefined} />
+            <AddressOutput
+                address={body}
+                copy={false}
+                label={ensName ?? undefined}
+            />
             {showStatus && (
                 <span className={classNames(style, 'lowercase')}>
                     {' '}

apps/app/src/plugins/sppPlugin/utils/sppSettingsUtils/sppSettingsUtils.test.ts

@@ -44,9 +44,8 @@ describe('sppSettings utils', () => {
             expect(result).toEqual([
                 {
                     term: 'app.plugins.spp.sppGovernanceSettings.default.name',
-                    copyValue: address,
                     definition: name,
-                    link,
+                    link: { href: url },
                 },
                 {
                     term: 'app.plugins.spp.sppGovernanceSettings.default.address',

apps/app/src/plugins/sppPlugin/utils/sppSettingsUtils/sppSettingsUtils.ts

@@ -65,9 +65,8 @@ class SppSettingsUtils {
         if (name != null) {
             settings.unshift({
                 term: t('app.plugins.spp.sppGovernanceSettings.default.name'),
-                copyValue: address,
                 definition: name,
-                link,
+                link: { href: url },
             });
         }