Closed
Conversation
* update aarch64 hv part in arceos (#15) * Modify platform configuration of aarch64-qemu-virt-hv for GICv2 with virtualization (#20) * refactor: totally remove hv related trap handlers from axhal/arch/aarch64 (#22) * Add gic trait impl (#26) * [refactor] remove hv related scripts and configs from arceos
- Add GicHypervisorInterface to interact with GIC Hypervisor - Implement GicInterface for setting List Register values - Update IRQ module to include new GIC-related functionalities
- Remove unused import of GicInterface for non-AArch64 targets - Add import of GicInterface and fetch_irq for AArch64 - Clean up unnecessary imports to improve code readability
hky1999
requested changes
Dec 18, 2024
hky1999
left a comment
hky1999
left a comment
There was a problem hiding this comment.
Please list all PRs related with vgic, and we can review&merge them together.
|
|
||
| #[cfg(target_arch = "aarch64")] | ||
| pub use crate::platform::irq::fetch_irq; | ||
| pub use crate::platform::irq::{fetch_irq, GicInterface}; |
There was a problem hiding this comment.
Is it a good way to expose this instance directly?
| static GICD: SpinNoIrq<GicDistributor> = | ||
| SpinNoIrq::new(GicDistributor::new(phys_to_virt(GICD_BASE).as_mut_ptr())); | ||
|
|
||
| static GICH: SpinNoIrq<GicHypervisorInterface> = SpinNoIrq::new(GicHypervisorInterface::new( |
There was a problem hiding this comment.
decorate it with #[cfg(feature = "hv")]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs: