Skip to content

Comments

refactor: AccessWidth is defined redundantly in both axvcpu and axa…#30

Merged
aarkegz merged 2 commits intomasterfrom
debin/remove_AccessWidth_from_axvcpu
Jun 7, 2025
Merged

refactor: AccessWidth is defined redundantly in both axvcpu and axa…#30
aarkegz merged 2 commits intomasterfrom
debin/remove_AccessWidth_from_axvcpu

Conversation

@luodeb
Copy link
Contributor

@luodeb luodeb commented Jun 6, 2025

…ddrspace. Remove it from axvcpu.

Rely on the following PRs
axvcpu
arm_vcpu
x86_vcpu

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the code to remove the redundant definition of AccessWidth from axvcpu, relying instead on the definition provided in axaddrspace.

  • Updated the import from axaddrspace to include device::AccessWidth
  • Removed the redundant import of AccessWidth from axvcpu

@aarkegz aarkegz self-requested a review June 7, 2025 13:19
Copy link
Contributor

@aarkegz aarkegz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aarkegz aarkegz merged commit 1e107bc into master Jun 7, 2025
10 of 12 checks passed
@aarkegz aarkegz deleted the debin/remove_AccessWidth_from_axvcpu branch June 7, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants