refactor: AccessWidth is defined redundantly in both axvcpu and axa…#17
Closed
refactor: AccessWidth is defined redundantly in both axvcpu and axa…#17
AccessWidth is defined redundantly in both axvcpu and axa…#17Conversation
…ddrspace. Remove it from axvcpu.
There was a problem hiding this comment.
Pull Request Overview
This PR refactors redundant definitions of AccessWidth by importing it from axaddrspace::device and removing the duplicate import from axvcpu.
- Added
device::AccessWidthto theaxaddrspaceimport and removed it from theaxvcpuimport. - Updated import grouping in
vmx/vcpu.rsto centralize type definitions in one module.
1906353110
pushed a commit
to 1906353110/x86_vcpu
that referenced
this pull request
Dec 26, 2025
…rceos-hypervisor#17) * feat: add vm_list and vcpu_list, import axtask for vcpu scheduling * refactor: move vmm related codes into vmm * Rebase to main branch, a few modifications to aarch64 related part of axvm * Modify vCpu vm-exit handing and some modication related with axaddrspace * Add doc comments in vmm/vcpus.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rely on the following PRs
axvcpu
arm_vcpu
x86_vcpu