Skip to content

tests(e2e): add e2e tests to verify status subresource for CRs using legacy annotations#1536

Merged
chengfang merged 1 commit intoargoproj-labs:masterfrom
chengfang:status.tests.annotation.cr
Mar 3, 2026
Merged

tests(e2e): add e2e tests to verify status subresource for CRs using legacy annotations#1536
chengfang merged 1 commit intoargoproj-labs:masterfrom
chengfang:status.tests.annotation.cr

Conversation

@chengfang
Copy link
Collaborator

@chengfang chengfang commented Mar 3, 2026

Summary by CodeRabbit

  • Tests
    • Enhanced test coverage to verify ImageUpdater status fields and conditions (ApplicationsMatched, ImagesManaged, LastCheckedAt, LastUpdatedAt, RecentUpdates, ObservedGeneration, Ready, and Error conditions) are properly updated after reconciliation.

…legacy annotations

Signed-off-by: Cheng Fang <cfang@redhat.com>
Co-authored-by: Claude <noreply@anthropic.com>
@coderabbitai
Copy link

coderabbitai bot commented Mar 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2a3d875 and 2a4fe16.

📒 Files selected for processing (1)
  • test/ginkgo/parallel/1-005-annotations-argocd_test.go

Walkthrough

The PR enhances test coverage in the ImageUpdater reconciliation test by adding runtime assertions to verify the CR's status fields (ApplicationsMatched, ImagesManaged, LastCheckedAt, LastUpdatedAt, RecentUpdates, ObservedGeneration) and condition states after reconciliation completes.

Changes

Cohort / File(s) Summary
ImageUpdater Status Verification
test/ginkgo/parallel/1-005-annotations-argocd_test.go
Adds EventuallyAssertions block to verify ImageUpdater CR status and conditions (Ready, Error) post-reconciliation. Duplicates verification in two locations. Imports apimeta for FindStatusCondition utility.

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding e2e tests to verify the status subresource for CRs using legacy annotations, which matches the file modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.35%. Comparing base (c1674be) to head (2a4fe16).
⚠️ Report is 47 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1536      +/-   ##
==========================================
+ Coverage   71.48%   73.35%   +1.87%     
==========================================
  Files          50       53       +3     
  Lines        4667     5082     +415     
==========================================
+ Hits         3336     3728     +392     
- Misses       1133     1145      +12     
- Partials      198      209      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chengfang chengfang merged commit f5ea867 into argoproj-labs:master Mar 3, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants