Skip to content

tests(e2e): add e2e tests to verify status subresource for CRs using legacy annotations #1536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chengfang merged 1 commit into from
Mar 3, 2026
+30 −0
Merged

tests(e2e): add e2e tests to verify status subresource for CRs using legacy annotations #1536

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions test/ginkgo/parallel/1-005-annotations-argocd_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import (
. "github.com/onsi/gomega"
appsv1 "k8s.io/api/apps/v1"
corev1 "k8s.io/api/core/v1"
apimeta "k8s.io/apimachinery/pkg/api/meta"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"

applicationFixture "github.com/argoproj-labs/argocd-image-updater/test/ginkgo/fixture/application"
Expand Down Expand Up @@ -203,6 +204,35 @@ var _ = Describe("ArgoCD Image Updater Parallel E2E Tests", func() {
// Return an empty string to signify the condition is not yet met.
return ""
}, "5m", "3s").Should(Equal("quay.io/dkarpele/my-guestbook:29437546.0"))

By("verifying ImageUpdater CR status reflects successful reconciliation")
Eventually(func(g Gomega) {
err := k8sClient.Get(ctx, client.ObjectKeyFromObject(imageUpdater), imageUpdater)
g.Expect(err).ToNot(HaveOccurred())

g.Expect(imageUpdater.Status.ApplicationsMatched).To(BeNumerically(">=", int32(1)),
"should match at least 1 application")
g.Expect(imageUpdater.Status.ImagesManaged).To(BeNumerically(">=", int32(1)),
"should manage at least 1 image")
g.Expect(imageUpdater.Status.LastCheckedAt).ToNot(BeNil(),
"lastCheckedAt should be set after reconciliation")
g.Expect(imageUpdater.Status.LastUpdatedAt).ToNot(BeNil(),
"lastUpdatedAt should be set after a successful image update")
g.Expect(imageUpdater.Status.RecentUpdates).ToNot(BeEmpty(),
"recentUpdates should not be empty after a successful image update")
g.Expect(imageUpdater.Status.ObservedGeneration).To(BeNumerically(">", int64(0)),
"observedGeneration should be set")

readyCondition := apimeta.FindStatusCondition(imageUpdater.Status.Conditions, "Ready")
g.Expect(readyCondition).ToNot(BeNil(), "Ready condition should be present")
g.Expect(readyCondition.Status).To(Equal(metav1.ConditionTrue),
"Ready condition should be True")

errorCondition := apimeta.FindStatusCondition(imageUpdater.Status.Conditions, "Error")
g.Expect(errorCondition).ToNot(BeNil(), "Error condition should be present")
g.Expect(errorCondition.Status).To(Equal(metav1.ConditionFalse),
"Error condition should be False for successful reconciliation")
}, "3m", "5s").Should(Succeed())
})
})
})
Loading