feat(controller): add --configmap-name flag to override controller ConfigMap#4664
feat(controller): add --configmap-name flag to override controller ConfigMap#4664a1exx-k wants to merge 1 commit intoargoproj:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4664 +/- ##
=======================================
Coverage 84.89% 84.89%
=======================================
Files 164 164
Lines 18966 18973 +7
=======================================
+ Hits 16101 16108 +7
Misses 2005 2005
Partials 860 860 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Published E2E Test Results 4 files 4 suites 3h 45m 1s ⏱️ For more details on these failures, see this check. Results for commit 2c0c631. ♻️ This comment has been updated with latest results. |
Published Unit Test Results2 454 tests 2 454 ✅ 3m 19s ⏱️ Results for commit 2c0c631. ♻️ This comment has been updated with latest results. |
44710f7 to
404ad5e
Compare
404ad5e to
89cb569
Compare
|
@zachaller - could you please review this change? |
…nfigMap The controller ConfigMap name was hardcoded to "argo-rollouts-config" with no way to override it. This adds a --configmap-name flag so operators can specify an alternative name, which is useful when running multiple controller instances in the same namespace or when the default name conflicts with existing resources. Signed-off-by: Alex Kazantcev <aleksandr.kazantcev@ticketmaster.co.uk> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
89cb569 to
2c0c631
Compare
|



Summary
argo-rollouts-configwith no way to override it at runtime--configmap-nameflag to theargo-rollouts-controllerbinary so operators can specify an alternative nameResolves #4665
Changes
cmd/rollouts-controller/main.go: new--configmap-nameflag (default:argo-rollouts-config)controller/controller.go:NewManagerandNewAnalysisManageraccept arolloutsConfigMapName stringparameter, replacing the hardcodeddefaults.DefaultRolloutsConfigMapNameconstant at the call sitescontroller/controller_test.go: updated call sites to passdefaults.DefaultRolloutsConfigMapNameChecklist:
"fix(controller): Updates such and such. Fixes #1234".🤖 Generated with Claude Code