Refactor(eos_designs): Move platform_settings.validate_hardware to validation_profiles

[MaheshGSLAB]

Change Summary

Move platform_settings.validate_hardware to validation_profiles

Related Issue(s)

Fixes #6243
Fixes #6327

Component(s) name

arista.avd.eos_designs

Proposed changes

One key will go under features

platform_settings:
    feature_support:
      # Enable hardware validation for the device.
      # If `false`, all hardware tests are skipped, therefore the other keys in `validate_hardware` are ignored.
      hardware_validation: <bool; default=True>

Make it default false for cEOS and vEOS like it is today

validation_profiles:
    name: <str, primary_key>
    # Max one level of inheritance
    parent_profile: <str>
    # Only considered when `platform_settings.feature_support.hardware_validation: true`
    hardware:
      # Minimum number of power supplies required for the device. Set to 0 to skip validation.
      min_power_supplies: <int>
      # Minimum number of fans required for the device. Set to 0 to skip validation.
      min_fans: <int>
      # Minimum number of supervisor modules required for the device. Set to 0 to skip validation.
      min_supervisors: <int>
      # Minimum number of line cards required for the device. Set to 0 to skip validation.
      min_line_cards: <int>
      # Minimum number of fabric cards required for the device. Set to 0 to skip validation.
      min_fabric_cards: <int>
      # List of approved transceiver manufacturers for the device.
      transceiver_manufacturers: 
    logging:
        # Threshold (in minutes) defining how far back to check the logging buffer for error-level logs during the validation performed by the `anta_runner` role.
        validate_no_errors_period: <int>
    # Exclude this node from being used as a destination target from other fabric devices in the extra fabric validation tests performed by the `anta_runner` role.
    exclude_as_extra_fabric_validation_target: <bool; default=False>
and under node_type_settings

l3leaf:
  nodes:
    - name: <str>
      validation_profile: <str>

How to test

Run molecule

Checklist

User Checklist

• N/A

Repository Checklist

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and documentation have been updated accordingly.
• I have updated molecule CI testing accordingly. (check the box if not applicable)

[github-actions]

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-6258
# Activate the virtual environment
source test-avd-pr-6258/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@issue-6243#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,issue-6243 --force
# Optional: Install AVD examples
cd test-avd-pr-6258
ansible-playbook arista.avd.install_examples

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[Shivani-gslab]

LGTM

[carl-baillargeon]

LGTM!

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[tkrenn-hc]

Would it be possible to note this change in the 6.0.0 porting guide?

[carl-baillargeon]

Would it be possible to note this change in the 6.0.0 porting guide?

@tkrenn-hc These are new eos_designs knobs that didn't exist in AVD 5.X. We will create a section in the porting guide to migrate from eos_validate_state to anta_runner using these new knobs if that's what you are referring to.