-
Notifications
You must be signed in to change notification settings - Fork 272
Refactor(eos_designs): Move platform_settings.validate_hardware to validation_profiles #6258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
7325e88
Refactor(eos_designs): Move platform_settings.validate_hardware to va…
MaheshGSLAB 9eda939
Merge branch 'devel' into issue-6243
MaheshGSLAB f46b0b9
updated the code to fix the default
MaheshGSLAB 4a5574f
improve the code
MaheshGSLAB cda7c88
Merge branch 'devel' into issue-6243
MaheshGSLAB 54d4ebe
Merge branch 'devel' into issue-6243
MaheshGSLAB d7c5012
added more unit tests
MaheshGSLAB db51f62
updated code for full coverage
MaheshGSLAB d3f7ba9
Merge branch 'devel' into issue-6243
MaheshGSLAB b6a17e4
Apply suggestions from code review
Shivani-gslab 67fd307
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 500b425
created the utils under metadata
MaheshGSLAB 80dff70
Merge branch 'devel' into issue-6243
MaheshGSLAB fe789cf
updated the schema, unit tests and code
MaheshGSLAB f5c612f
Update ansible_collections/arista/avd/extensions/molecule/eos_designs…
MaheshGSLAB 733e9b2
Merge branch 'devel' into issue-6243
MaheshGSLAB 4078cdc
Merge branch 'devel' into issue-6243
gmuloc 7220948
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 29d5612
Apply suggestions from code review
MaheshGSLAB 204f00a
Merge branch 'devel' into issue-6243
gmuloc d3e2562
Merge branch 'devel' into issue-6243
MaheshGSLAB 71a1b79
updated the descriptions
MaheshGSLAB 2f04ddf
Merge branch 'devel' into issue-6243
carl-baillargeon 9d94078
Move kernel_ecmp_cli to another doc section
carl-baillargeon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 0 additions & 5 deletions
5
...collections/arista/avd/extensions/molecule/anta_runner/inventory/host_vars/dc1-spine1.yml
This file was deleted.
Oops, something went wrong.
21 changes: 21 additions & 0 deletions
21
...eos_designs_negative_unit_tests/inventory/host_vars/missing-validation-parent-profile.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| type: l3leaf | ||
| l3leaf: | ||
| defaults: | ||
| platform: vEOS-LAB | ||
| loopback_ipv4_pool: 192.168.255.0/24 | ||
| vtep_loopback_ipv4_pool: 192.168.254.0/24 | ||
| bgp_as: 65101 | ||
| nodes: | ||
| - name: missing-validation-parent-profile | ||
| id: 1 | ||
| mgmt_ip: 192.168.200.105/24 | ||
| validation_profile: profile1 | ||
|
|
||
| validation_profiles: | ||
| - name: profile1 | ||
| parent_profile: profile2 | ||
| hardware: | ||
| min_power_supplies: 2 | ||
|
|
||
| expected_error_message: >- | ||
| Parent validation profile 'profile2' referenced by validation profile 'profile1' is not defined under 'validation_profiles'. |
20 changes: 20 additions & 0 deletions
20
...lecule/eos_designs_negative_unit_tests/inventory/host_vars/missing-validation-profile.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| type: l3leaf | ||
| l3leaf: | ||
| defaults: | ||
| platform: vEOS-LAB | ||
| loopback_ipv4_pool: 192.168.255.0/24 | ||
| vtep_loopback_ipv4_pool: 192.168.254.0/24 | ||
| bgp_as: 65101 | ||
| nodes: | ||
| - name: missing-validation-profile | ||
| id: 1 | ||
| mgmt_ip: 192.168.200.105/24 | ||
| validation_profile: profile1 | ||
|
|
||
| validation_profiles: | ||
| - name: profile2 | ||
| hardware: | ||
| min_power_supplies: 2 | ||
|
|
||
| expected_error_message: >- | ||
| Validation profile 'profile1' referenced in node configuration is not defined under 'validation_profiles'. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
72 changes: 72 additions & 0 deletions
72
...a/avd/extensions/molecule/eos_designs_unit_tests/intended/configs/validation-profiles.cfg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| ! | ||
| no enable password | ||
| no aaa root | ||
| ! | ||
| vlan internal order ascending range 1006 1199 | ||
| ! | ||
| transceiver qsfp default-mode 4x10G | ||
| ! | ||
| service routing protocols model multi-agent | ||
| ! | ||
| hostname validation-profiles | ||
| ! | ||
| vrf instance MGMT | ||
| ! | ||
| interface Loopback0 | ||
| description ROUTER_ID | ||
| no shutdown | ||
| ip address 192.168.255.1/32 | ||
| ! | ||
| interface Loopback1 | ||
| description VXLAN_TUNNEL_SOURCE | ||
| no shutdown | ||
| ip address 192.168.254.1/32 | ||
| ! | ||
| interface Management1 | ||
| description OOB_MANAGEMENT | ||
| no shutdown | ||
| vrf MGMT | ||
| ip address 192.168.200.105/24 | ||
| ! | ||
| interface Vxlan1 | ||
| description validation-profiles_VTEP | ||
| vxlan source-interface Loopback1 | ||
| vxlan udp-port 4789 | ||
| ! | ||
| ip routing | ||
| no ip routing vrf MGMT | ||
| ! | ||
| ip prefix-list PL-LOOPBACKS-EVPN-OVERLAY | ||
| seq 10 permit 192.168.255.0/24 eq 32 | ||
| seq 20 permit 192.168.254.0/24 eq 32 | ||
| ! | ||
| route-map RM-CONN-2-BGP permit 10 | ||
| match ip address prefix-list PL-LOOPBACKS-EVPN-OVERLAY | ||
| ! | ||
| router bfd | ||
| multihop interval 300 min-rx 300 multiplier 3 | ||
| ! | ||
| router bgp 65101 | ||
| router-id 192.168.255.1 | ||
| update wait-install | ||
| no bgp default ipv4-unicast | ||
| maximum-paths 4 | ||
| neighbor EVPN-OVERLAY-PEERS peer group | ||
| neighbor EVPN-OVERLAY-PEERS update-source Loopback0 | ||
| neighbor EVPN-OVERLAY-PEERS bfd | ||
| neighbor EVPN-OVERLAY-PEERS ebgp-multihop 3 | ||
| neighbor EVPN-OVERLAY-PEERS send-community | ||
| neighbor EVPN-OVERLAY-PEERS maximum-routes 0 | ||
| neighbor IPv4-UNDERLAY-PEERS peer group | ||
| neighbor IPv4-UNDERLAY-PEERS send-community | ||
| neighbor IPv4-UNDERLAY-PEERS maximum-routes 12000 | ||
| redistribute connected route-map RM-CONN-2-BGP | ||
| ! | ||
| address-family evpn | ||
| neighbor EVPN-OVERLAY-PEERS activate | ||
| ! | ||
| address-family ipv4 | ||
| no neighbor EVPN-OVERLAY-PEERS activate | ||
| neighbor IPv4-UNDERLAY-PEERS activate | ||
| ! | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
112 changes: 112 additions & 0 deletions
112
...sions/molecule/eos_designs_unit_tests/intended/structured_configs/validation-profiles.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,112 @@ | ||
| aaa_root: | ||
| disabled: true | ||
| config_end: true | ||
| enable_password: | ||
| disabled: true | ||
| hostname: validation-profiles | ||
| ip_igmp_snooping: | ||
| globally_enabled: true | ||
| ip_routing: true | ||
| loopback_interfaces: | ||
| - name: Loopback0 | ||
| description: ROUTER_ID | ||
| shutdown: false | ||
| ip_address: 192.168.255.1/32 | ||
| - name: Loopback1 | ||
| description: VXLAN_TUNNEL_SOURCE | ||
| shutdown: false | ||
| ip_address: 192.168.254.1/32 | ||
| management_interfaces: | ||
| - name: Management1 | ||
| description: OOB_MANAGEMENT | ||
| shutdown: false | ||
| vrf: MGMT | ||
| ip_address: 192.168.200.105/24 | ||
| type: oob | ||
| metadata: | ||
| is_deployed: true | ||
| platform: vEOS-LAB | ||
| fabric_name: EOS_DESIGNS_UNIT_TESTS | ||
| validate_hardware: | ||
| min_power_supplies: 2 | ||
| min_fans: 4 | ||
| min_supervisors: 2 | ||
| min_line_cards: 10 | ||
| min_fabric_cards: 5 | ||
| transceiver_manufacturers: | ||
| - Third-party vendor profile1 | ||
| validate_no_errors_period: 2 | ||
| exclude_as_extra_fabric_validation_target: true | ||
| prefix_lists: | ||
| - name: PL-LOOPBACKS-EVPN-OVERLAY | ||
| sequence_numbers: | ||
| - sequence: 10 | ||
| action: permit 192.168.255.0/24 eq 32 | ||
| - sequence: 20 | ||
| action: permit 192.168.254.0/24 eq 32 | ||
| route_maps: | ||
| - name: RM-CONN-2-BGP | ||
| sequence_numbers: | ||
| - sequence: 10 | ||
| type: permit | ||
| match: | ||
| - ip address prefix-list PL-LOOPBACKS-EVPN-OVERLAY | ||
| router_bfd: | ||
| multihop: | ||
| interval: 300 | ||
| min_rx: 300 | ||
| multiplier: 3 | ||
| router_bgp: | ||
| as: '65101' | ||
| router_id: 192.168.255.1 | ||
| maximum_paths: | ||
| paths: 4 | ||
| updates: | ||
| wait_install: true | ||
| bgp: | ||
| default: | ||
| ipv4_unicast: false | ||
| peer_groups: | ||
| - name: IPv4-UNDERLAY-PEERS | ||
| metadata: | ||
| type: ipv4 | ||
| send_community: all | ||
| maximum_routes: 12000 | ||
| - name: EVPN-OVERLAY-PEERS | ||
| metadata: | ||
| type: evpn | ||
| update_source: Loopback0 | ||
| bfd: true | ||
| ebgp_multihop: 3 | ||
| send_community: all | ||
| maximum_routes: 0 | ||
| redistribute: | ||
| connected: | ||
| enabled: true | ||
| route_map: RM-CONN-2-BGP | ||
| address_family_evpn: | ||
| peer_groups: | ||
| - name: EVPN-OVERLAY-PEERS | ||
| activate: true | ||
| address_family_ipv4: | ||
| peer_groups: | ||
| - name: IPv4-UNDERLAY-PEERS | ||
| activate: true | ||
| - name: EVPN-OVERLAY-PEERS | ||
| activate: false | ||
| service_routing_protocols_model: multi-agent | ||
| transceiver_qsfp_default_mode_4x10: true | ||
| vlan_internal_order: | ||
| allocation: ascending | ||
| range: | ||
| beginning: 1006 | ||
| ending: 1199 | ||
| vrfs: | ||
| - name: MGMT | ||
| ip_routing: false | ||
| vxlan_interface: | ||
| vxlan1: | ||
| description: validation-profiles_VTEP | ||
| vxlan: | ||
| source_interface: Loopback1 | ||
| udp_port: 4789 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.