[Downstream change][LLVM][SROA] Teach SROA how to "bitcast" between fixed and scalable vectors #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ixed and scalable vectors.
It's a cherry-pick from the sve-vls-sroa branch of Paul Walker's LLVM fork.
Ongoing upstream attempt:
llvm/llvm-project#130973
Downstream issue: #218
For function whose vscale_range is limited to a single value we can
size scalable vectors. This aids SROA by allowing scalable vector
load and store operations to be considered for replacement whereby
bitcasts through memory can be replaced by vector insert or extract
operations.
pawosm-arm
requested review from
DavidTruby,
dcandler,
kiranchandramohan,
peterwaller-arm,
pratlucas and
voltur01
Contributor
Author
|
@huntergr-arm or @davemgreen can I ask you for a comment which other approvers could refer to? I'm lacking candidates with domain knowledge to make it land.... |
Contributor
|
Did the cherry-pick happen cleanly? |
Contributor
Author
Yes, not a single conflict. |
Contributor
I can confirm this PR matches my original implementation and is safe to land. |
pawosm-arm
deleted the
users/pawosm-arm/release/arm-software/20.x/atfl-sve-vls-sroa
branch
pratlucas
pushed a commit
that referenced
this pull request
Jun 25, 2025
…st" between fixed and scalable vectors. (#399) This PR contains two commits: - revert of "[Downstream change][LLVM][SROA] Teach SROA how to "bitcast" between fixed and scalable vectors (#219)" - backport of usprtream's "[LLVM][SROA] Teach SROA how to "bitcast" between fixed and scalable vectors." Downstream issue: #218 --------- Co-authored-by: Paul Walker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a cherry-pick from the sve-vls-sroa branch of Paul Walker's LLVM fork.
Ongoing upstream attempt:
llvm/llvm-project#130973
Downstream issue: #218
For function whose vscale_range is limited to a single value we can size scalable vectors. This aids SROA by allowing scalable vector load and store operations to be considered for replacement whereby bitcasts through memory can be replaced by vector insert or extract operations.