Skip to content

Realtek 8189ES & FS compatibility with Linux 6.17.y#8677

Merged
igorpecovnik merged 1 commit intomainfrom
igorpecovnik-patch-3
Sep 28, 2025
Merged

Realtek 8189ES & FS compatibility with Linux 6.17.y#8677
igorpecovnik merged 1 commit intomainfrom
igorpecovnik-patch-3

Conversation

@igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Sep 27, 2025

Description

Closing #8659

How Has This Been Tested?

  • CI test

Checklist:

  • My changes generate no new warnings

@igorpecovnik igorpecovnik requested a review from a team as a code owner September 27, 2025 11:20
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 27, 2025

Walkthrough

The PR updates lib/functions/compilation/patch/drivers_network.sh. It removes upper kernel-version bounds from two Realtek driver conditionals, leaving only a minimum version check (>= 3.14) for RTL8189ES and RTL8189FS patch application. It also updates the commit hashes and associated date comments for rtl8189esver and rtl8189fsver.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • rpardini
  • krachlatte
  • leggewie
  • EvilOlaf
  • chainsx

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Description Check ❓ Inconclusive The pull request description only references closing an issue and marks test checkboxes without summarizing the actual modifications to the kernel-version gating or commit hash updates for the Realtek 8189ES/FS drivers, making it too generic to confirm it aligns with the detailed changeset. It does not describe any part of the patch or its intent beyond linking an issue number. Consequently, it is inconclusive whether the description adequately reflects the changes. Please expand the description to include a concise summary of the key changes introduced, such as the removal of upper bound kernel-version checks for the RTL8189ES/FS patches and the updates to commit hashes, so reviewers can easily verify that the description matches the actual modifications.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The title clearly indicates the pull request’s purpose to extend compatibility for the Realtek 8189ES and FS drivers to Linux 6.17.y, which directly reflects the kernel-gating and patch updates implemented in the changeset. It is concise, specific, and highlights the main change without unnecessary detail.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch igorpecovnik-patch-3

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@igorpecovnik igorpecovnik added the Build Executing build train (permission needed) label Sep 27, 2025
@github-actions github-actions bot added 11 Milestone: Fourth quarter release size/small PR with less then 50 lines Needs review Seeking for review Framework Framework components labels Sep 27, 2025
@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Sep 27, 2025
@igorpecovnik igorpecovnik merged commit eebef46 into main Sep 28, 2025
1 check passed
@igorpecovnik igorpecovnik deleted the igorpecovnik-patch-3 branch September 28, 2025 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

11 Milestone: Fourth quarter release Build Executing build train (permission needed) Framework Framework components Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines

Development

Successfully merging this pull request may close these issues.

1 participant