arm64: dts: rockchip: add Mekotronics R58X 4x4 #440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- from vendor / balbes, which never got merged into a real branch - renamed files a bit, still a mess - fixes: - don't force panthor, remove duplicate gpu nodes all around - disable sata node, there's no SATA, avoid deferred probe - rename led to what it really is - try to fix indentation with tabs, eat trailing whitespace - remove `#if 1`'s
amazingfate
approved these changes
Dec 24, 2025
rpardini
commented
Dec 24, 2025
| #include <dt-bindings/display/rockchip_vop.h> | ||
| #include <dt-bindings/sensor-dev.h> | ||
| #include "rk3588-cpu-swap.dtsi" | ||
|
|
Member
Author
There was a problem hiding this comment.
Has anyone seen this stuff before? Seems it "swaps" the big cores with the little ones.
How does this make any sense....?
Member
Author
There was a problem hiding this comment.
It simply doesn't make sense. Ported to mainline sans any of this and works fine.
rpardini
commented
Dec 24, 2025
Comment on lines
+96
to
+130
| &cluster0_opp_table { | ||
| /delete-node/ opp-408000000; | ||
| /delete-node/ opp-600000000; | ||
| /delete-node/ opp-816000000; | ||
| /delete-node/ opp-1008000000; | ||
| }; | ||
|
|
||
| &cluster1_opp_table { | ||
| /delete-node/ opp-408000000; | ||
| /delete-node/ opp-600000000; | ||
| /delete-node/ opp-816000000; | ||
| /delete-node/ opp-1008000000; | ||
| }; | ||
|
|
||
| &cluster2_opp_table { | ||
| /delete-node/ opp-408000000; | ||
| /delete-node/ opp-600000000; | ||
| /delete-node/ opp-816000000; | ||
| /delete-node/ opp-1008000000; | ||
| }; | ||
|
|
||
| &cpu_l0 { | ||
| cpu-supply = <&vdd_cpu_lit_s0>; | ||
| mem-supply = <&vdd_cpu_lit_mem_s0>; | ||
| }; | ||
|
|
||
| &cpu_b0 { | ||
| cpu-supply = <&vdd_cpu_big0_s0>; | ||
| mem-supply = <&vdd_cpu_big0_mem_s0>; | ||
| }; | ||
|
|
||
| &cpu_b2 { | ||
| cpu-supply = <&vdd_cpu_big1_s0>; | ||
| mem-supply = <&vdd_cpu_big1_mem_s0>; | ||
| }; |
Member
Author
There was a problem hiding this comment.
This looks absolutely cuckoo to me. Can anyone make sense of it (eg in context of porting this to mainline kernel)?
Member
Author
There was a problem hiding this comment.
It simply doesn't make any sense. Ported to mainline without any of this and works fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
arm64: dts: rockchip: add Mekotronics R58X 4x4
mekotronicbranch for some reason)#if 1's