Feature/final additional tweak#2
Open
arminsabouri wants to merge 13 commits intofrost-upstream-mainfrom
Open
Conversation
…#794) Co-authored-by: Mergify <37929162+mergify[bot]@users.noreply.github.com>
…oundation#797) * core: prevent creating a zero identifier with deserialization * move test to file which is not copied to other ciphersuites --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* Refresh shares with DKG (ZcashFoundation#663) * Add verification step for round2_packages for refreshing shares with DKG (ZcashFoundation#663) * Clean up clippy issues for correct indexing with refreshing shares with DKG (ZcashFoundation#663) * Import refresh tests for all ciphersuites (ZcashFoundation#663) * Fix formatting (ZcashFoundation#663)
arminsabouri
force-pushed
the
feature/final-additional-tweak
branch
2 times, most recently
from
3122186 to
fe6dad1
Compare
…e x-only pk (ZcashFoundation#815) Per BIP-341 if there is no script paths the internal key should still be tapTweak'd by tG where t = TaggedHash(P_x). Before this commit the internal key and the taproot output key are the same if no script paths are used. This is because the tweak is the 0 scalar value so Q = P + tG = P. It is worth noting that Bitcoin's consensus would still accept a non-taptweak'd internal key as it verifies a signature against whatever pk is used in the witness program. So the outputs are still spendable, however it deviates from the spec.
arminsabouri
force-pushed
the
feature/final-additional-tweak
branch
from
fe6dad1 to
be21f86
Compare
arminsabouri
force-pushed
the
feature/final-additional-tweak
branch
from
be21f86 to
c018ae3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: