You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After reviewing the code, I found that we don't really need the extract_and_remove_bundle step for the extraction. The extract_contents.py already recursively looks for files that need to be extracted, so we can finish all the extraction in this step. Additionally, this file seems to only remove the "outermost" package, while keeping the default setting delete to be False for files other than the "outermost". This helps prevent RData files from being deleted once they have been unpacked.
For this case, the code change in this PR is to remove the extract_and_remove_bundle function.
Meghanxuxx
changed the title
Fixed the Problem: Dataverse Transfer Fails at "Parse Dataverse METS …
Fixed the Problem(Step 1): Dataverse Transfer Fails at "Parse Dataverse METS …
Apr 24, 2025
@Meghanxuxx I think you need to rebase your pull request branch on top of the latest qa/0.x branch. For example, all of our imports in Python are absolute now.
Also notice the linting job is failing in the test workflow. We use pre-commit for linting the Archivematica code bases. Once you install it you can run pre-commit run --all-files on the top of any Archivematica repository and it should automatically fix linting problems or point where the errors are coming from.
Hi @Meghanxuxx - as I mentioned in your Archivematica PRs, we'll be starting testing in a little over a week for 1.18 so we'll stop accepting contributions around then. If you want to address the failed tests in your PRs and have any questions, please let us know. Thank you for your contributions!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CommunityPull requests that have been contributed from community members outside Artefactual
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Related: archivematica/Issues#1745
After reviewing the code, I found that we don't really need the extract_and_remove_bundle step for the extraction. The extract_contents.py already recursively looks for files that need to be extracted, so we can finish all the extraction in this step. Additionally, this file seems to only remove the "outermost" package, while keeping the default setting
deleteto be False for files other than the "outermost". This helps prevent RData files from being deleted once they have been unpacked.For this case, the code change in this PR is to remove the extract_and_remove_bundle function.