Skip to content

Fixed the Problem(Step 1): Dataverse Transfer Fails at "Parse Dataverse METS …#772

Open
Meghanxuxx wants to merge 1 commit intoartefactual:qa/0.xfrom
Meghanxuxx:dev/issue-1745-Parse-Dataverse-METS-XML-Fails
Open

Fixed the Problem(Step 1): Dataverse Transfer Fails at "Parse Dataverse METS …#772
Meghanxuxx wants to merge 1 commit intoartefactual:qa/0.xfrom
Meghanxuxx:dev/issue-1745-Parse-Dataverse-METS-XML-Fails

Conversation

@Meghanxuxx
Copy link

Issue Related: archivematica/Issues#1745

After reviewing the code, I found that we don't really need the extract_and_remove_bundle step for the extraction. The extract_contents.py already recursively looks for files that need to be extracted, so we can finish all the extraction in this step. Additionally, this file seems to only remove the "outermost" package, while keeping the default setting delete to be False for files other than the "outermost". This helps prevent RData files from being deleted once they have been unpacked.

For this case, the code change in this PR is to remove the extract_and_remove_bundle function.

@Meghanxuxx Meghanxuxx changed the title Fixed the Problem: Dataverse Transfer Fails at "Parse Dataverse METS … Fixed the Problem(Step 1): Dataverse Transfer Fails at "Parse Dataverse METS … Apr 24, 2025
@replaceafill
Copy link
Member

@Meghanxuxx I think you need to rebase your pull request branch on top of the latest qa/0.x branch. For example, all of our imports in Python are absolute now.

Also notice the linting job is failing in the test workflow. We use pre-commit for linting the Archivematica code bases. Once you install it you can run pre-commit run --all-files on the top of any Archivematica repository and it should automatically fix linting problems or point where the errors are coming from.

@sarah-mason sarah-mason added the Community Pull requests that have been contributed from community members outside Artefactual label Apr 28, 2025
@sarah-mason
Copy link
Contributor

Hi @Meghanxuxx - as I mentioned in your Archivematica PRs, we'll be starting testing in a little over a week for 1.18 so we'll stop accepting contributions around then. If you want to address the failed tests in your PRs and have any questions, please let us know. Thank you for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Community Pull requests that have been contributed from community members outside Artefactual

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants