fix(tui): correct cursor tracking for group reorder K/J#399
Open
essentialols wants to merge 1 commit intoasheshgoplani:mainfrom
Open
fix(tui): correct cursor tracking for group reorder K/J#399essentialols wants to merge 1 commit intoasheshgoplani:mainfrom
essentialols wants to merge 1 commit intoasheshgoplani:mainfrom
Conversation
When reordering groups with K/J, the cursor now tracks to the group's actual position after rebuilding the flat item list. Previously the cursor moved by a fixed offset of 1, which was incorrect when the adjacent group had expanded sessions (the group header would jump over multiple flat items). Also switches group reorder persistence from saveInstances() to the lighter-weight saveGroupState(), since only group Order values change. Fixes asheshgoplani#398
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
saveGroupState()(lightweight, no Touch trigger) instead ofsaveInstances(), since only group Order values changeTest plan
go build ./...compiles cleanlygo test ./internal/session/ -run MoveGroup -vpassesFixes #398