Skip to content

Conversation

@alexeagle
Copy link
Member

clang-tidy will flag as an unnecessary copy (performance-unnecessary-value-param)

clang-tidy will flag as an unnecessary copy (performance-unnecessary-value-param)
@aspect-workflows
Copy link
Contributor

aspect-workflows bot commented Nov 19, 2025

Test

All tests were cache hits

26 tests (100.0%) were fully cached saving 44s.


Lint

.

2 issues require fixes
1 issues can be fixed automatically

💡 Auto-fix linting errors with:

bazel lint //speller/main:build-dictionary --fix

Buildifier      Format      Gazelle


for_each(common_words.begin(), common_words.end(),
[&](const string &word) { engine.AddEntry(word); });
[&](string word) { engine.AddEntry(word); });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ClangTidy provided a suggestion

Suggested change
[&](string word) { engine.AddEntry(word); });
[&](const string& word) { engine.AddEntry(word); });

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants