Skip to content

Change lambda parameter to pass by value #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change lambda parameter to pass by value #484

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion speller/main/build-dictionary.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

using namespace std;

const list<string> common_words{

Check warning on line 10 in speller/main/build-dictionary.cc

View check run for this annotation

Aspect Workflows / Lint

ClangTidy found an issue 

initialization of 'common_words' with static storage duration may throw an exception that cannot be caught [cert-err58-cpp]
"a", "about", "after", "all", "also", "an", "and",
"any", "as", "at", "back", "be", "because", "but",
"by", "can", "come", "could", "day", "do", "even",
Expand All @@ -29,7 +29,7 @@
Speller::LookupEngine engine("spell.db", true);

for_each(common_words.begin(), common_words.end(),
[&](const string &word) { engine.AddEntry(word); });
[&](string word) { engine.AddEntry(word); });

Check warning on line 32 in speller/main/build-dictionary.cc

View check run for this annotation

Aspect Workflows / Lint

ClangTidy found an issue 

the parameter 'word' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
Copy link
Contributor

@aspect-workflows aspect-workflows bot Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ClangTidy provided a suggestion

Suggested change
[&](string word) { engine.AddEntry(word); });
[&](const string& word) { engine.AddEntry(word); });


return 0;
}