Skip to content

Update to ASP.NET Core 11 preview 2#385

Merged
martincostello merged 4 commits intodev-v11from
dotnet-11-preview.2
Mar 10, 2026
Merged

Update to ASP.NET Core 11 preview 2#385
martincostello merged 4 commits intodev-v11from
dotnet-11-preview.2

Conversation

@martincostello
Copy link
Member

Update to preview 2 of ASP.NET Core 11.

Update to preview 2 of ASP.NET Core 11.
Fix badge merge.
Use overload that takes a `StringComparison`.
@martincostello martincostello marked this pull request as ready for review March 10, 2026 19:57
Copilot AI review requested due to automatic review settings March 10, 2026 19:57
@martincostello martincostello merged commit cd55248 into dev-v11 Mar 10, 2026
12 checks passed
@martincostello martincostello deleted the dotnet-11-preview.2 branch March 10, 2026 19:57
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository to ASP.NET Core 11 preview 2 by bumping the .NET SDK/tooling and related ASP.NET Core test package versions, plus a small tweak in OpenID option initialization.

Changes:

  • Bump global.json SDK + tool versions to 11.0.100-preview.2.26159.112.
  • Update centralized package versions for Microsoft.AspNetCore.Mvc.Testing and Microsoft.AspNetCore.TestHost to preview 2.
  • Increment prerelease iteration from preview 1 to preview 2 in versioning props.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/AspNet.Security.OpenId/OpenIdAuthenticationInitializer.cs Adjusts authority trailing-slash check to use a StringComparison overload.
global.json Updates pinned .NET SDK/tool version to preview 2.
eng/Versions.props Updates prerelease iteration number to 2.
Directory.Packages.props Updates ASP.NET Core test package versions to preview 2.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

}

if (!options.Authority.OriginalString.EndsWith('/'))
if (!options.Authority.OriginalString.EndsWith('/', StringComparison.Ordinal))
Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

string.EndsWith('/', StringComparison.Ordinal) is not an overload available on string in current stable .NET APIs, and it also won’t bind to MemoryExtensions.EndsWith because a char can’t be converted to ReadOnlySpan<char>. This risks a compile break. Prefer EndsWith("/", StringComparison.Ordinal) (string literal) if you want an explicit comparison, or keep the EndsWith('/') char overload.

Suggested change
if (!options.Authority.OriginalString.EndsWith('/', StringComparison.Ordinal))
if (!options.Authority.OriginalString.EndsWith("/", StringComparison.Ordinal))

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants