Update to ASP.NET Core 11 preview 2#385
Conversation
Update to preview 2 of ASP.NET Core 11.
Fix badge merge.
Use overload that takes a `StringComparison`.
There was a problem hiding this comment.
Pull request overview
Updates the repository to ASP.NET Core 11 preview 2 by bumping the .NET SDK/tooling and related ASP.NET Core test package versions, plus a small tweak in OpenID option initialization.
Changes:
- Bump
global.jsonSDK + tool versions to11.0.100-preview.2.26159.112. - Update centralized package versions for
Microsoft.AspNetCore.Mvc.TestingandMicrosoft.AspNetCore.TestHostto preview 2. - Increment prerelease iteration from preview 1 to preview 2 in versioning props.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/AspNet.Security.OpenId/OpenIdAuthenticationInitializer.cs | Adjusts authority trailing-slash check to use a StringComparison overload. |
| global.json | Updates pinned .NET SDK/tool version to preview 2. |
| eng/Versions.props | Updates prerelease iteration number to 2. |
| Directory.Packages.props | Updates ASP.NET Core test package versions to preview 2. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
|
|
||
| if (!options.Authority.OriginalString.EndsWith('/')) | ||
| if (!options.Authority.OriginalString.EndsWith('/', StringComparison.Ordinal)) |
There was a problem hiding this comment.
string.EndsWith('/', StringComparison.Ordinal) is not an overload available on string in current stable .NET APIs, and it also won’t bind to MemoryExtensions.EndsWith because a char can’t be converted to ReadOnlySpan<char>. This risks a compile break. Prefer EndsWith("/", StringComparison.Ordinal) (string literal) if you want an explicit comparison, or keep the EndsWith('/') char overload.
| if (!options.Authority.OriginalString.EndsWith('/', StringComparison.Ordinal)) | |
| if (!options.Authority.OriginalString.EndsWith("/", StringComparison.Ordinal)) |
Update to preview 2 of ASP.NET Core 11.