Skip to content

Update to ASP.NET Core 11 preview 2 #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martincostello merged 4 commits into from
Mar 10, 2026
Merged

Update to ASP.NET Core 11 preview 2 #385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
52996f6
Update to ASP.NET Core 11 preview 2
martincostello Mar 10, 2026
56c2e8c
Merge branch 'dev-v11' into dotnet-11-preview.2
martincostello Mar 10, 2026
ad04fe1
Fix merge conflict
martincostello Mar 10, 2026
2182b7b
Fix CA1307 warning
martincostello Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
<PackageVersion Include="JetBrains.Annotations" Version="2025.2.4" />
<PackageVersion Include="JustEat.HttpClientInterception" Version="5.1.2" />
<PackageVersion Include="MartinCostello.Logging.XUnit" Version="0.7.1" />
<PackageVersion Include="Microsoft.AspNetCore.Mvc.Testing" Version="11.0.0-preview.1.26104.118" />
<PackageVersion Include="Microsoft.AspNetCore.TestHost" Version="11.0.0-preview.1.26104.118" />
<PackageVersion Include="Microsoft.AspNetCore.Mvc.Testing" Version="11.0.0-preview.2.26159.112" />
<PackageVersion Include="Microsoft.AspNetCore.TestHost" Version="11.0.0-preview.2.26159.112" />
<PackageVersion Include="Microsoft.IdentityModel.Protocols" Version="8.14.0" />
<PackageVersion Include="Shouldly" Version="4.3.0" />
</ItemGroup>
</Project>
</Project>
2 changes: 1 addition & 1 deletion eng/Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<VersionPrefix>$(MajorVersion).$(MinorVersion).$(PatchVersion)</VersionPrefix>
<PackageValidationBaselineVersion Condition=" '$(EnablePackageValidation)' == 'true' AND '$(PackageValidationBaselineVersion)' == '' ">11.0.0</PackageValidationBaselineVersion>
<PreReleaseVersionLabel>preview</PreReleaseVersionLabel>
<PreReleaseVersionIteration>1</PreReleaseVersionIteration>
<PreReleaseVersionIteration>2</PreReleaseVersionIteration>
<PreReleaseBrandingLabel>Preview $(PreReleaseVersionIteration)</PreReleaseBrandingLabel>
<StabilizePackageVersion Condition="'$(StabilizePackageVersion)' == ''">false</StabilizePackageVersion>
<DotNetFinalVersionKind Condition="'$(StabilizePackageVersion)' == 'true'">release</DotNetFinalVersionKind>
Expand Down
4 changes: 2 additions & 2 deletions global.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
{
"sdk": {
"version": "11.0.100-preview.1.26104.118",
"version": "11.0.100-preview.2.26159.112",
"allowPrerelease": true,
"rollForward": "major"
},

"tools": {
"dotnet": "11.0.100-preview.1.26104.118"
"dotnet": "11.0.100-preview.2.26159.112"
},

"msbuild-sdks": {
Expand Down
2 changes: 1 addition & 1 deletion src/AspNet.Security.OpenId/OpenIdAuthenticationInitializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ public void PostConfigure([NotNull] string? name, [NotNull] TOptions options)
throw new ArgumentException("The authority cannot contain a fragment or a query string.", nameof(options));
}

if (!options.Authority.OriginalString.EndsWith('/'))
if (!options.Authority.OriginalString.EndsWith('/', StringComparison.Ordinal))
Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

string.EndsWith('/', StringComparison.Ordinal) is not an overload available on string in current stable .NET APIs, and it also won’t bind to MemoryExtensions.EndsWith because a char can’t be converted to ReadOnlySpan<char>. This risks a compile break. Prefer EndsWith("/", StringComparison.Ordinal) (string literal) if you want an explicit comparison, or keep the EndsWith('/') char overload.

Suggested change
if (!options.Authority.OriginalString.EndsWith('/', StringComparison.Ordinal))
if (!options.Authority.OriginalString.EndsWith("/", StringComparison.Ordinal))

Copilot uses AI. Check for mistakes.
{
options.Authority = new Uri(options.Authority.OriginalString + "/", UriKind.Absolute);
}
Expand Down