Stop using HttpResponse::stream method #1947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jderusse
force-pushed
the
stream-fix
branch
2 times, most recently
from
6f4c714 to
0361dc9
Compare
jderusse
force-pushed
the
stream-fix
branch
from
0361dc9 to
717fa9c
Compare
derrabus
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cURL does not allows to stream a response when performing another request.
Therefore, the current implementation that leverages the symfony's
HttpResponse::streammethod might trigger exception if the stream is used in another request. (ie. copying file usingclient->upload('2', client->download('1'))).This PR removes the use of
HttpResponse::streamand fallbacks to the genericResponseBodyStreamthat buffers the entire response in a temporary file, which consumes the entire stream before processing the request and avoid the issue.fix #1944