Skip to content

Conversation

@DarshanCode2005
Copy link
Contributor

fixes: #1881

Description

Refactored createHttpWithAuthResolver function to reduce cognitive complexity from 16 to below 15, addressing SonarCloud linting issues.

Changes

  • Extracted fetchWithErrorHandling helper function to consolidate repeated fetch error handling logic
  • Extracted fetchGitHubApiContent helper function to handle GitHub API-specific logic
  • Simplified the main read function by removing nested conditionals and using early returns
  • Maintained all existing functionality and behavior

Benefits

  • Reduced cognitive complexity from 16 to below 15 (SonarCloud requirement)
  • Improved code maintainability by separating concerns
  • Better error handling consistency across different URL types
  • No functional changes - all existing tests pass

Testing

  • Unit tests passed

@changeset-bot
Copy link

changeset-bot bot commented Jan 7, 2026

⚠️ No Changeset found

Latest commit: 54e1a4c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@DarshanCode2005
Copy link
Contributor Author

Hi @Shurtu-gal sir, @AayushSaini101 sir,
Could you please take a look at this small contribution? It’s related to the SonarCloud cognitive complexity issue shown here: https://sonarcloud.io/project/issues?impactSeverities=HIGH&issueStatuses=OPEN%2CCONFIRMED&id=asyncapi_cli&open=AZolEeT_NbtcVyNcQgsK

@AayushSaini101
Copy link
Collaborator

/u

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 8, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To Triage

Development

Successfully merging this pull request may close these issues.

Fix Sonar Cloud issues in the CLI Project

3 participants