Skip to content

refactor: reduce cognitive complexity in createHttpWithAuthResolver #1957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DarshanCode2005 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

refactor: reduce cognitive complexity in createHttpWithAuthResolver #1957

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d91517b
refactor: reduce cognitive complexity in HTTP auth resolver
DarshanCode2005 Jan 7, 2026
54e1a4c
Merge branch 'master' into master
asyncapi-bot Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
92 changes: 58 additions & 34 deletions src/domains/services/validation.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,50 @@ const convertGitHubWebUrl = (url: string): string => {
return url;
};

/**
* Helper function to fetch with error handling
*/
const fetchWithErrorHandling = async (
url: string,
headers: Record<string, string>,
errorMessage: string,
): Promise<Response> => {
const res = await fetch(url, { headers });
if (!res.ok) {
throw new Error(`${errorMessage}: ${url} - ${res.statusText}`);
}
return res;
};

/**
* Helper function to fetch content from GitHub API
*/
const fetchGitHubApiContent = async (
url: string,
headers: Record<string, string>,
): Promise<string> => {
headers['Accept'] = 'application/vnd.github.v3+json';
const res = await fetchWithErrorHandling(
url,
headers,
'Failed to fetch GitHub API URL',
);
const fileInfo = (await res.json()) as GitHubFileInfo;

if (!fileInfo.download_url) {
throw new Error(
`No download URL found in GitHub API response for: ${url}`,
);
}

const contentRes = await fetchWithErrorHandling(
fileInfo.download_url,
headers,
'Failed to fetch content from download URL',
);
return await contentRes.text();
};

/**
* Custom resolver for private repositories
*/
Expand Down Expand Up @@ -108,43 +152,23 @@ const createHttpWithAuthResolver = () => ({
}

if (url.includes('api.github.com')) {
headers['Accept'] = 'application/vnd.github.v3+json';
const res = await fetch(url, { headers });
if (!res.ok) {
throw new Error(
`Failed to fetch GitHub API URL: ${url} - ${res.statusText}`
);
}
const fileInfo = (await res.json()) as GitHubFileInfo;

if (fileInfo.download_url) {
const contentRes = await fetch(fileInfo.download_url, { headers });
if (!contentRes.ok) {
throw new Error(
`Failed to fetch content from download URL: ${fileInfo.download_url} - ${contentRes.statusText}`
);
}
return await contentRes.text();
}
throw new Error(
`No download URL found in GitHub API response for: ${url}`
);
} else if (url.includes('raw.githubusercontent.com')) {
return await fetchGitHubApiContent(url, headers);
}
if (url.includes('raw.githubusercontent.com')) {
headers['Accept'] = 'application/vnd.github.v3.raw';
const res = await fetch(url, { headers });
if (!res.ok) {
throw new Error(
`Failed to fetch GitHub URL: ${url} - ${res.statusText}`
);
}
return await res.text();
} else {
const res = await fetch(url, { headers });
if (!res.ok) {
throw new Error(`Failed to fetch URL: ${url} - ${res.statusText}`);
}
const res = await fetchWithErrorHandling(
url,
headers,
'Failed to fetch GitHub URL',
);
return await res.text();
}
const res = await fetchWithErrorHandling(
url,
headers,
'Failed to fetch URL',
);
return await res.text();
},
});

Expand Down
Loading