Add toggle buttons for 'No Playlist Advance' using ① (U+2460)

[jlindgren90]

Alternative approach to:

• Add toggle buttons for 'No Playlist Advance' #181

Unicode ① (U+2460) seems like a suitable graphic for the buttons and avoids having to add new icons, which would not fit in with the system icon theme anyway.

I also changed the button order (repeat, shuffle, no playlist advance) and fixed up the gtkui implementation, which wasn't updating the toggle button properly at startup or when toggled via menu/hotkey.

[jlindgren90]

@radioactiveman care to review this?

It makes the UI to play/repeat a single track much more visible and is a nice improvement IMHO.

Ideally there would be a standard themed icon for this, but I don't know of one.

[radioactiveman]

The code looks fine but using a label as icon is not feasible. It doesn't fit with symbolic icons and for gtkui it also increases tool button sizes for some reason.

Before:

After: Notice the shorter slider and wider buttons

Many themes (unfortunately not all...) contain a "media-playlist-repeat-song" icon which would fit perfectly. But with Qt it is somehow not working, so it's also no valid option.

My suggestion would be using "go-last" as icon. Most themes use an arrow (can indicate playlist advance) and vertical bar (can indicate a barrier where playlist advancing stops). What do you think?

[radioactiveman]

It would be also nice to allow hiding this button with a configuration setting (button hidden by default). I personally never enable "No playlist advance" and don't like wasting space in the UI.

[jlindgren90]

The "go-last" icon seems like a bit of a stretch - it won't be very obvious what it does.

If the button isn't useful enough to the add to the toolbar by default, maybe we just forget it for now? The option is already there in the menu, and power users who care enough about the feature can use the keyboard shortcut.

I'll set this to draft for now, in case we want to revisit it later.

[radioactiveman]

Maybe we just forget it for now? The option is already there in the menu, and power users who care enough about the feature can use the keyboard shortcut.

OK, sounds reasonable to me.

[sunhaitao]

If the button isn't useful enough to the add to the toolbar by default, maybe we just forget it for now? The option is already there in the menu, and power users who care enough about the feature can use the keyboard shortcut.

The key problem here is it is hard to tell whether "No Playlist Advance" is enabled.

[sunhaitao]

The "go-last" icon seems like a bit of a stretch - it won't be very obvious what it does.

The "go-next" icon seems more fitting.