Create test for shell and tube heat exchanger problem by mattfalcone1997 · Pull Request #55 · aurora-multiphysics/hippo

mattfalcone1997 · 2025-06-17T12:28:30Z

Summary

Creates regression test and example for shell and tube heat exchanger problem. The simulation lasts 500 seconds, but for the regression test this is reduced to 10 seconds.

Related Issue

Resolves #25

Checklist

Tests have been written for the new/changed behaviour.
Documentation/examples have been added/updated for the new changes.

mattfalcone1997 · 2025-07-03T08:59:05Z

For the moment, I have made the test run in serial. There seems to be some non-deterministic behaviour meaning it fails in parallel. I have opened a new issue for that #61 and recommend merging this as is. Once the non-determinism is resolved, we can update the tests.

k-collie · 2025-07-04T13:11:13Z

Do you know why there are changes in test/tests/problems/foam_problem/copies_values_from_openfoam_boundary? Most look like they just re-order/re-format things but the initial conditions for nut/omega/p/p_rgh have changed/been removed.

mattfalcone1997 · 2025-07-04T13:46:55Z

Do you know why there are changes in test/tests/problems/foam_problem/copies_values_from_openfoam_boundary? Most look like they just re-order/re-format things but the initial conditions for nut/omega/p/p_rgh have changed/been removed.

I just wanted the parallel and serial test to be the exact same, other than running in serial and parallel. I do not believe it makes any significant difference to the results.

k-collie

Still checking but these are the things we just discussed

test/tests/multiapps/shell_tube_heat_exchanger/README.md

...ems/foam_problem/copies_values_from_openfoam_boundary/buoyantFoam_serial/buoyantCavity/0/nut

mattfalcone1997 · 2025-07-11T15:06:34Z

I've updated the test to use an end time of 10 and simplified the prep.sh so it does the downloading and merely cleans, downloads meshes and partitions

k-collie

Some more comments, still going

test/tests/multiapps/shell_tube_heat_exchanger/fluid_inner/clean.sh

test/tests/multiapps/shell_tube_heat_exchanger/fluid_inner/run.sh

test/tests/multiapps/shell_tube_heat_exchanger/fluid_outer/clean.sh

test/tests/multiapps/shell_tube_heat_exchanger/fluid_outer/run.sh

...s/foam_problem/copies_values_from_openfoam_boundary/buoyantFoam_serial/buoyantCavity/0/p_rgh

k-collie

Some more comments

test/tests/multiapps/shell_tube_heat_exchanger/README.md

test/tests/multiapps/shell_tube_heat_exchanger/prep.sh

test/tests/multiapps/shell_tube_heat_exchanger/inner.i

test/tests/multiapps/shell_tube_heat_exchanger/outer.i

test/tests/multiapps/shell_tube_heat_exchanger/solid.i

test/tests/multiapps/shell_tube_heat_exchanger/fluid_outer/Allclean

test/tests/multiapps/shell_tube_heat_exchanger/prep.sh

test/tests/multiapps/shell_tube_heat_exchanger/solid.i

…shell tube test

test/tests/multiapps/shell_tube_heat_exchanger/solid.exo

test/tests/multiapps/shell_tube_heat_exchanger/gold/solid_out.e

k-collie

Great job getting this working. Thanks for putting up with my review 😆

mattfalcone1997 · 2025-07-18T08:41:57Z

Your feedback made it better!

mattfalcone1997 mentioned this pull request Jun 17, 2025

Allow CI to run as non-root user #56

Merged

2 tasks

mattfalcone1997 force-pushed the shell_tube_test branch from 2ce5aa9 to 93054ee Compare June 18, 2025 12:21

mattfalcone1997 mentioned this pull request Jun 18, 2025

Retain wmake when stripping sources to allow dynamic code generation #57

Merged

mattfalcone1997 force-pushed the shell_tube_test branch from b71908b to 3588d42 Compare June 18, 2025 16:28

mattfalcone1997 mentioned this pull request Jun 20, 2025

Update install-openfoam.sh #59

Closed

mattfalcone1997 added 7 commits June 30, 2025 10:55

Create test for shell and tube heat exchanger problem

210407e

Create README.md for shell and tube heat exchanger problem

78acee4

Remove heavy test as unnecessary

fec9f99

Check if exodiff error eliminated using near location transfer

ab09bac

Make serial and parallel buoyantCavity case files the same

26e8271

Shell and tube make download optional in prep script

df8c799

Make shell and tube test serial for now

c9229c9

mattfalcone1997 force-pushed the shell_tube_test branch from 09a7505 to c9229c9 Compare July 3, 2025 08:42

mattfalcone1997 marked this pull request as ready for review July 3, 2025 08:59

mattfalcone1997 requested a review from k-collie July 3, 2025 09:00

mattfalcone1997 added 2 commits July 4, 2025 16:34

Fix bug in transfers for shell and tube HX

365cfae

Update shell tube test to use 2 cores

c96a651

k-collie reviewed Jul 11, 2025

View reviewed changes

test/tests/multiapps/shell_tube_heat_exchanger/README.md Outdated Show resolved Hide resolved

...ems/foam_problem/copies_values_from_openfoam_boundary/buoyantFoam_serial/buoyantCavity/0/nut Show resolved Hide resolved

Simplif shell tube test by setting end time to 10 initially

28d794f

k-collie reviewed Jul 11, 2025

View reviewed changes

Remove unnecessary scripts from OpenFOAM directories

9959fa7

k-collie reviewed Jul 17, 2025

View reviewed changes

test/tests/multiapps/shell_tube_heat_exchanger/fluid_outer/Allclean Outdated Show resolved Hide resolved

mattfalcone1997 added 3 commits July 17, 2025 14:26

Add file hash checking and refactor

fc19cac

Update comments in input files and README

3b4f1f2

Remove unnecessary commands from Allclean

de6d1fb

simplify shell and tube prep file

a815467

k-collie reviewed Jul 17, 2025

View reviewed changes

test/tests/multiapps/shell_tube_heat_exchanger/prep.sh Outdated Show resolved Hide resolved

k-collie reviewed Jul 17, 2025

View reviewed changes

test/tests/multiapps/shell_tube_heat_exchanger/prep.sh Show resolved Hide resolved

k-collie reviewed Jul 17, 2025

View reviewed changes

test/tests/multiapps/shell_tube_heat_exchanger/solid.i Show resolved Hide resolved

k-collie reviewed Jul 17, 2025

View reviewed changes

test/tests/multiapps/shell_tube_heat_exchanger/solid.i Show resolved Hide resolved

Update comments and allow mesh not to be redownloaded if present for …

abcc107

…shell tube test

mattfalcone1997 requested a review from k-collie July 17, 2025 15:07

k-collie reviewed Jul 17, 2025

View reviewed changes

test/tests/multiapps/shell_tube_heat_exchanger/solid.exo Show resolved Hide resolved

k-collie reviewed Jul 17, 2025

View reviewed changes

test/tests/multiapps/shell_tube_heat_exchanger/gold/solid_out.e Show resolved Hide resolved

k-collie approved these changes Jul 18, 2025

View reviewed changes

mattfalcone1997 merged commit da5b3bd into aurora-multiphysics:main Jul 18, 2025
2 checks passed

mattfalcone1997 deleted the shell_tube_test branch July 18, 2025 08:42

Conversation

mattfalcone1997 commented Jun 17, 2025

Summary

Related Issue

Checklist

Uh oh!

mattfalcone1997 commented Jul 3, 2025

Uh oh!

k-collie commented Jul 4, 2025

Uh oh!

mattfalcone1997 commented Jul 4, 2025

Uh oh!

k-collie left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mattfalcone1997 commented Jul 11, 2025

Uh oh!

k-collie left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

k-collie left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

k-collie left a comment

Choose a reason for hiding this comment

Uh oh!

mattfalcone1997 commented Jul 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants